#24483 fix breaks dynamic choices

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

#24483 fix breaks dynamic choices

Marcin Nowak
Hi.

Fix of #24483 breaks possibility to declare dynamic choices for model's fields.
I read the ticket and I understand the initial problem, but it was used frequently to support dynamic choices.

Now we have always consistent but static choices, tests are passing, migrations have consistent choices list (never used, but they are there), but we lost an important functionality.

It would be nice to bring back previous behaviour and fix the problem on the migrations/keepdb side, not in models.

BR,
M

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/00b9fee3-d3e1-4ee8-811e-ac38ef7b8992%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: #24483 fix breaks dynamic choices

Marcin Nowak


Fix of #24483 breaks possibility to declare dynamic choices for model's fields.
I read the ticket and I understand the initial problem, but it was used frequently to support dynamic choices.

Now we have always consistent but static choices, tests are passing, migrations have consistent choices list (never used, but they are there), but we lost an important functionality.

It would be nice to bring back previous behaviour and fix the problem on the migrations/keepdb side, not in models.


BUMP

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/3347abe8-9474-4b0a-ab04-e952c4623808%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: #24483 fix breaks dynamic choices

Carlton Gibson-3

It's not clear from your OP what you mean by "dynamic choices" (I can still provide a callable; is that not "dynamic"?) 

Your best bet it to draw up a reproducible example (or even better a test case) of exactly the behaviour that used to work but now doesn't. 
I'd suggest putting that in a new Trac ticket referencing #24483. 

Then we've got something concrete to go on. 

Kind Regards,

Carlton

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0ede9c71-5946-4f85-abc5-e1073647438e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.