Any interest in integrating Django Admin Sortable into core?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Any interest in integrating Django Admin Sortable into core?

Brandon Taylor-2
Hello Django Developers,

I've been a longtime user (since before the "newforms-admin" branch) and proponent of Django and am the creator and maintainer of Django Admin Sortable: https://github.com/iambrandontaylor/django-admin-sortable

I've been fortunate enough in my career to have been able to do Django full-time as the former Lead Developer of The Texas Tribune, a Principal Developer at USA Today and as a Technical Architect at Inmar in North Carolina. So thank you, for such a great framework and for making so many years of my life so enjoyable as a developer.

If you're not familiar with Django Admin Sortable, it's a mixin-based way to add drag-and-drop ordering to just about any kind of object in Django Admin - something I needed to do on basically every Django project I ever built. Other popular frameworks such as Keystone.js have drag-and-drop ordering baked into them, so why not Django? I'm hoping you could take what I've done and not only integrate it, but make it better in ways I couldn't. I personally think it would be awesome to simply be able to add a Meta property to a model to enable this functionality without having to inherit the Mixin.

It would be an honor to be able to contribute to Django's core functionality after so many years of using the framework. I'm hopeful you'll consider my proposal.

Kindest Regards,
Brandon Taylor

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/389733b0-cccf-4359-9cc7-0d6883f9d495%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Any interest in integrating Django Admin Sortable into core?

Adam Johnson-2
Hi Brandon,

Thanks for offering to contribute.

I'm not particularly familiar with the admin but from a quick look I see django-admin-sortable uses jQuery UI to support its functionality, whilst contrib.admin doesn't use it. I don't think there's a strict policy on whether new JS libraries should be integrated in contrib.admin but I can imagine adding jQuery UI being a little complicated since it could break for users who have already added jQuery UI themselves.

Also from experience, if something gets merged to core it can slow down its development. Tying the releases to Django's means that improvements are slower to be released and this can even discourage contributions. If it was up to me I'd devolve some of the apps in contrib into separate packages :)

Adam

On 20 March 2017 at 20:56, Brandon Taylor <[hidden email]> wrote:
Hello Django Developers,

I've been a longtime user (since before the "newforms-admin" branch) and proponent of Django and am the creator and maintainer of Django Admin Sortable: https://github.com/iambrandontaylor/django-admin-sortable

I've been fortunate enough in my career to have been able to do Django full-time as the former Lead Developer of The Texas Tribune, a Principal Developer at USA Today and as a Technical Architect at Inmar in North Carolina. So thank you, for such a great framework and for making so many years of my life so enjoyable as a developer.

If you're not familiar with Django Admin Sortable, it's a mixin-based way to add drag-and-drop ordering to just about any kind of object in Django Admin - something I needed to do on basically every Django project I ever built. Other popular frameworks such as Keystone.js have drag-and-drop ordering baked into them, so why not Django? I'm hoping you could take what I've done and not only integrate it, but make it better in ways I couldn't. I personally think it would be awesome to simply be able to add a Meta property to a model to enable this functionality without having to inherit the Mixin.

It would be an honor to be able to contribute to Django's core functionality after so many years of using the framework. I'm hopeful you'll consider my proposal.

Kindest Regards,
Brandon Taylor

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/389733b0-cccf-4359-9cc7-0d6883f9d495%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Adam

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3TGJHBWQLeeZmxiDmR6EKPoYbTU7q0GS8RnLW4A5ctyw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Any interest in integrating Django Admin Sortable into core?

Brandon Taylor-2
Morning Adam,

I can certainly refactor jQuery-UI out of this code. Aside from performance improvements, the core of django-admin-sortable has remained almost the same for about 5 years - or longer... I can't even remember when I created it - I'm getting old!

Let me see what I can do in that regard, if you feel it would raise the chances of it getting pulled in?

On Tuesday, March 21, 2017 at 3:16:09 AM UTC-4, Adam Johnson wrote:
Hi Brandon,

Thanks for offering to contribute.

I'm not particularly familiar with the admin but from a quick look I see django-admin-sortable uses jQuery UI to support its functionality, whilst contrib.admin doesn't use it. I don't think there's a strict policy on whether new JS libraries should be integrated in contrib.admin but I can imagine adding jQuery UI being a little complicated since it could break for users who have already added jQuery UI themselves.

Also from experience, if something gets merged to core it can slow down its development. Tying the releases to Django's means that improvements are slower to be released and this can even discourage contributions. If it was up to me I'd devolve some of the apps in contrib into separate packages :)

Adam

On 20 March 2017 at 20:56, Brandon Taylor <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="Y-N9PpK0CAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">also...@...> wrote:
Hello Django Developers,

I've been a longtime user (since before the "newforms-admin" branch) and proponent of Django and am the creator and maintainer of Django Admin Sortable: <a href="https://github.com/iambrandontaylor/django-admin-sortable" style="color:rgb(126,87,194)" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fiambrandontaylor%2Fdjango-admin-sortable\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHfNyJilQpqeRzz005DmVS9lA1tCw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fiambrandontaylor%2Fdjango-admin-sortable\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHfNyJilQpqeRzz005DmVS9lA1tCw&#39;;return true;">https://github.com/iambrandontaylor/django-admin-sortable

I've been fortunate enough in my career to have been able to do Django full-time as the former Lead Developer of The Texas Tribune, a Principal Developer at USA Today and as a Technical Architect at Inmar in North Carolina. So thank you, for such a great framework and for making so many years of my life so enjoyable as a developer.

If you're not familiar with Django Admin Sortable, it's a mixin-based way to add drag-and-drop ordering to just about any kind of object in Django Admin - something I needed to do on basically every Django project I ever built. Other popular frameworks such as Keystone.js have drag-and-drop ordering baked into them, so why not Django? I'm hoping you could take what I've done and not only integrate it, but make it better in ways I couldn't. I personally think it would be awesome to simply be able to add a Meta property to a model to enable this functionality without having to inherit the Mixin.

It would be an honor to be able to contribute to Django's core functionality after so many years of using the framework. I'm hopeful you'll consider my proposal.

Kindest Regards,
Brandon Taylor

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="Y-N9PpK0CAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">django-develop...@googlegroups.com.
To post to this group, send email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="Y-N9PpK0CAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">django-d...@googlegroups.com.
Visit this group at <a href="https://groups.google.com/group/django-developers" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/group/django-developers&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/group/django-developers&#39;;return true;">https://groups.google.com/group/django-developers.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/django-developers/389733b0-cccf-4359-9cc7-0d6883f9d495%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/django-developers/389733b0-cccf-4359-9cc7-0d6883f9d495%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/django-developers/389733b0-cccf-4359-9cc7-0d6883f9d495%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/django-developers/389733b0-cccf-4359-9cc7-0d6883f9d495%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.



--
Adam

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/b97a6e05-89dc-413e-bdd4-3114a5e9ab59%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...