Anything missing on #7560? (the only critical Jython-compatibility patch left)

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Anything missing on #7560? (the only critical Jython-compatibility patch left)

Leo Soto M.

Hi django-devs!,

As the GSoC period is on the final weeks, I'd like to see if there is
anything wrong or missing with #7560, so I can help to get it
committed before beta1, and have the time to adjust the Django/Jython
code and documentation if the patch needs more tweaking.

Basically, our target is that by the release of django-1.0-beta1 and
jython-2.5-alpha2 people can start to try Django on Jython without
having to apply any third party patch. I know that Django have many
other goals which are competing for scarce core devs time, but I'd
greatelly appreciate some help here. Also note that patch doesn't just
help the writing of Jython database backends. As discussed previously
here it includes some cleanup that makes easier to write backends, and
also small improvements with fields too.

Thanks!,
--
Leo Soto M.
http://blog.leosoto.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)

Malcolm Tredinnick

Hi Leo,

On Mon, 2008-07-28 at 11:51 -0400, Leo Soto M. wrote:
> Hi django-devs!,
>
> As the GSoC period is on the final weeks, I'd like to see if there is
> anything wrong or missing with #7560, so I can help to get it
> committed before beta1, and have the time to adjust the Django/Jython
> code and documentation if the patch needs more tweaking.

I started reviewing this with a view to committing it last night. Then
somebody distracted me with an offer of going out for beer. It looks
pretty much fine. I need to make sure it integrates well with something
Ivan Sagalaev has tossed up in another ticket, but it should land in
pretty much a form identical to what's there. I'll get it committed in
the next 24 hours.

Regards,
Malcolm



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)

Jacob Kaplan-Moss-3

On Mon, Jul 28, 2008 at 11:56 AM, Malcolm Tredinnick
<[hidden email]> wrote:
> I started reviewing this with a view to committing it last night. Then
> somebody distracted me with an offer of going out for beer. It looks
> pretty much fine. I need to make sure it integrates well with something
> Ivan Sagalaev has tossed up in another ticket, but it should land in
> pretty much a form identical to what's there. I'll get it committed in
> the next 24 hours.

Just for the record, I've also reviewed this patch and am happy with
it (I told Leo to bring it up here).

Jacob

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)

Leo Soto M.

On Mon, Jul 28, 2008 at 1:08 PM, Jacob Kaplan-Moss
<[hidden email]> wrote:

>
> On Mon, Jul 28, 2008 at 11:56 AM, Malcolm Tredinnick
> <[hidden email]> wrote:
>> I started reviewing this with a view to committing it last night. Then
>> somebody distracted me with an offer of going out for beer. It looks
>> pretty much fine. I need to make sure it integrates well with something
>> Ivan Sagalaev has tossed up in another ticket, but it should land in
>> pretty much a form identical to what's there. I'll get it committed in
>> the next 24 hours.
>
> Just for the record, I've also reviewed this patch and am happy with
> it (I told Leo to bring it up here).

Thanks folks!
--
Leo Soto M.
http://blog.leosoto.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

vcc
Reply | Threaded
Open this post in threaded view
|

Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)

vcc
Greate!

Test with django-pyodbc <http://code.google.com/p/django-pyodbc>  OK, now external backends no need patch django core anymore.

Thanks.

Wei guangjing

----- Original Message -----
From: "Leo Soto M." <[hidden email]>
To: <[hidden email]>
Sent: Tuesday, July 29, 2008 1:20 AM
Subject: Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)


>
> On Mon, Jul 28, 2008 at 1:08 PM, Jacob Kaplan-Moss
> <[hidden email]> wrote:
>>
>> On Mon, Jul 28, 2008 at 11:56 AM, Malcolm Tredinnick
>> <[hidden email]> wrote:
>>> I started reviewing this with a view to committing it last night. Then
>>> somebody distracted me with an offer of going out for beer. It looks
>>> pretty much fine. I need to make sure it integrates well with something
>>> Ivan Sagalaev has tossed up in another ticket, but it should land in
>>> pretty much a form identical to what's there. I'll get it committed in
>>> the next 24 hours.
>>
>> Just for the record, I've also reviewed this patch and am happy with
>> it (I told Leo to bring it up here).
>
> Thanks folks!
> --
> Leo Soto M.
> http://blog.leosoto.com
>
> >
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)

Leo Soto M.

Oops, looks like I messed up two docstrings (spotted by Ramiro
Morales). Just filled #8028 to fix that.

--
Leo Soto M.
http://blog.leosoto.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: Anything missing on #7560? (the only critical Jython-compatibility patch left)

Adam V.

I've updated django-mssql to work with this patch too.

Big thanks to Leo and the Django devs for this change.
- Adam V.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---