DEP 0008 (Formatting using Black) is accepted

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

DEP 0008 (Formatting using Black) is accepted

Andrew Godwin-3
Hi everyone,

The Technical Board has voted on DEP 0008 (https://github.com/django/deps/blob/master/accepted/0008-black.rst), after the extensive discussion here and the updates done as a result.

The board voted in favour, and so I've moved the DEP into the accepted directory.

One of the key changes to the proposal was to wait until Black got to a stable (1.0) release, so it will sit in "accepted" until that happens, at which point we will do the implementation (including the big reformat itself) and then move the DEP to "final".

There's no hard timeline on when Black will hit a stable release, but it's very close; there are a few changes we'd like to make sure are included when we reformat Django, such as keeping lists with trailing commas on multiple lines (https://github.com/python/black/pull/826). That's why we're waiting for the stable release rather than reformatting now.

Thanks to everyone who chimed in on the discussion - this was not an easy decision, and the feedback helped a lot to work out what was best for us.

I also want to personally thank Herman Schistad, for prompting this discussion, and Aymeric Augustin, for his work on writing and updating the DEP!

Yours in auto-formatting,
Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1uox9b7i895zS0pymzJ-kUQtd_USkQi-%3DbY-q58noo3Mmg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: DEP 0008 (Formatting using Black) is accepted

Andrew Godwin-3
One quick clarification - when I said "stable (1.0)" release, I in fact meant the first release that the Black project officially marks as stable.

Black doesn't use versioning that would result in a stable release being called 1.0, as far as I know, given they are on 19.3b0 right now!

Andrew

On Friday, May 10, 2019 at 6:46:37 PM UTC-7, Andrew Godwin wrote:
Hi everyone,

The Technical Board has voted on DEP 0008 (<a href="https://github.com/django/deps/blob/master/accepted/0008-black.rst" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdeps%2Fblob%2Fmaster%2Faccepted%2F0008-black.rst\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFncT22g4zr6g8C3qnowCIFH2u90w&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdeps%2Fblob%2Fmaster%2Faccepted%2F0008-black.rst\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFncT22g4zr6g8C3qnowCIFH2u90w&#39;;return true;">https://github.com/django/deps/blob/master/accepted/0008-black.rst), after the extensive discussion here and the updates done as a result.

The board voted in favour, and so I've moved the DEP into the accepted directory.

One of the key changes to the proposal was to wait until Black got to a stable (1.0) release, so it will sit in "accepted" until that happens, at which point we will do the implementation (including the big reformat itself) and then move the DEP to "final".

There's no hard timeline on when Black will hit a stable release, but it's very close; there are a few changes we'd like to make sure are included when we reformat Django, such as keeping lists with trailing commas on multiple lines (<a href="https://github.com/python/black/pull/826" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fpython%2Fblack%2Fpull%2F826\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEscPlGdnbHBD2uCC_JE7NK6_a6Yg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fpython%2Fblack%2Fpull%2F826\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEscPlGdnbHBD2uCC_JE7NK6_a6Yg&#39;;return true;">https://github.com/python/black/pull/826). That's why we're waiting for the stable release rather than reformatting now.

Thanks to everyone who chimed in on the discussion - this was not an easy decision, and the feedback helped a lot to work out what was best for us.

I also want to personally thank Herman Schistad, for prompting this discussion, and Aymeric Augustin, for his work on writing and updating the DEP!

Yours in auto-formatting,
Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/c7cd08c4-6d16-4141-b21c-438306a8d458%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: DEP 0008 (Formatting using Black) is accepted

Michael-7
I'm disappointed to learn that this was merged without a healthy debate on the deps repo. 

On Friday, May 10, 2019 at 8:53:44 PM UTC-5, Andrew Godwin wrote:
One quick clarification - when I said "stable (1.0)" release, I in fact meant the first release that the Black project officially marks as stable.

Black doesn't use versioning that would result in a stable release being called 1.0, as far as I know, given they are on 19.3b0 right now!

Andrew

On Friday, May 10, 2019 at 6:46:37 PM UTC-7, Andrew Godwin wrote:
Hi everyone,

The Technical Board has voted on DEP 0008 (<a href="https://github.com/django/deps/blob/master/accepted/0008-black.rst" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdeps%2Fblob%2Fmaster%2Faccepted%2F0008-black.rst\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFncT22g4zr6g8C3qnowCIFH2u90w&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdeps%2Fblob%2Fmaster%2Faccepted%2F0008-black.rst\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFncT22g4zr6g8C3qnowCIFH2u90w&#39;;return true;">https://github.com/django/deps/blob/master/accepted/0008-black.rst), after the extensive discussion here and the updates done as a result.

The board voted in favour, and so I've moved the DEP into the accepted directory.

One of the key changes to the proposal was to wait until Black got to a stable (1.0) release, so it will sit in "accepted" until that happens, at which point we will do the implementation (including the big reformat itself) and then move the DEP to "final".

There's no hard timeline on when Black will hit a stable release, but it's very close; there are a few changes we'd like to make sure are included when we reformat Django, such as keeping lists with trailing commas on multiple lines (<a href="https://github.com/python/black/pull/826" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fpython%2Fblack%2Fpull%2F826\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEscPlGdnbHBD2uCC_JE7NK6_a6Yg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fpython%2Fblack%2Fpull%2F826\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEscPlGdnbHBD2uCC_JE7NK6_a6Yg&#39;;return true;">https://github.com/python/black/pull/826). That's why we're waiting for the stable release rather than reformatting now.

Thanks to everyone who chimed in on the discussion - this was not an easy decision, and the feedback helped a lot to work out what was best for us.

I also want to personally thank Herman Schistad, for prompting this discussion, and Aymeric Augustin, for his work on writing and updating the DEP!

Yours in auto-formatting,
Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/8f6f5de0-f489-4271-9c2e-af3b0a97f365%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: DEP 0008 (Formatting using Black) is accepted

Tom Forbes
There has been a particularly healthy debate on the mailing list, I think it was clear that a consensus was not going to be reached. Are there any points you wanted to bring up there that where not already made on the mailing list thread?

Tom

On 11 May 2019, at 17:30, Michael Martinez <[hidden email]> wrote:

I'm disappointed to learn that this was merged without a healthy debate on the deps repo. 

On Friday, May 10, 2019 at 8:53:44 PM UTC-5, Andrew Godwin wrote:
One quick clarification - when I said "stable (1.0)" release, I in fact meant the first release that the Black project officially marks as stable.

Black doesn't use versioning that would result in a stable release being called 1.0, as far as I know, given they are on 19.3b0 right now!

Andrew

On Friday, May 10, 2019 at 6:46:37 PM UTC-7, Andrew Godwin wrote:
Hi everyone,

The Technical Board has voted on DEP 0008 (https://github.com/django/deps/blob/master/accepted/0008-black.rst), after the extensive discussion here and the updates done as a result.

The board voted in favour, and so I've moved the DEP into the accepted directory.

One of the key changes to the proposal was to wait until Black got to a stable (1.0) release, so it will sit in "accepted" until that happens, at which point we will do the implementation (including the big reformat itself) and then move the DEP to "final".

There's no hard timeline on when Black will hit a stable release, but it's very close; there are a few changes we'd like to make sure are included when we reformat Django, such as keeping lists with trailing commas on multiple lines (https://github.com/python/black/pull/826). That's why we're waiting for the stable release rather than reformatting now.

Thanks to everyone who chimed in on the discussion - this was not an easy decision, and the feedback helped a lot to work out what was best for us.

I also want to personally thank Herman Schistad, for prompting this discussion, and Aymeric Augustin, for his work on writing and updating the DEP!

Yours in auto-formatting,
Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/8f6f5de0-f489-4271-9c2e-af3b0a97f365%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/B3F49C9A-FAE8-41BA-A9EE-06222826B54F%40tomforb.es.
For more options, visit https://groups.google.com/d/optout.