[Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path

Django
#19528: CachedFilesMixin does not rewrite rules for css selector with path
--------------------------------+------------------------------------------
     Reporter:  mike@…          |      Owner:  nobody
         Type:  Bug             |     Status:  new
    Component:                  |    Version:  1.4
  contrib.staticfiles           |   Keywords:  CachedFilesMixin staticfiles
     Severity:  Normal          |  Has patch:  0
 Triage Stage:  Unreviewed      |      UI/UX:  0
Easy pickings:  0               |
--------------------------------+------------------------------------------
 Using CachedFilesMixin we'll have paths like this
 `<img alt="True" src="/media/static/admin/img/icon-yes.0596085e212f.gif">`
 after template rendering, but an unmodified selector:
 `img[src$="admin/img/icon-yes.gif"]` in processed stylesheet.

 This happens because CachedFilesMixin.patterns does not contain a rule
 like this `"""(img\[src[\^\$\*]{0,1}=\s*["']\s*(.*?)["'])"""` to match
 against and actually can not deal with `^=|$=|*=` operators. I am not sure
 how such paths can be properly processed, though.

--
Ticket URL: <https://code.djangoproject.com/ticket/19528>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path

Django
#19528: CachedFilesMixin does not rewrite rules for css selector with path
-------------------------------------+-------------------------------------
     Reporter:  mike@…               |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.staticfiles  |                  Version:  1.4
     Severity:  Normal               |               Resolution:
     Keywords:  CachedFilesMixin     |             Triage Stage:  Accepted
  staticfiles                        |      Needs documentation:  0
    Has patch:  0                    |  Patch needs improvement:  0
  Needs tests:  0                    |                    UI/UX:  0
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by akaariai):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Totally out of my expertise area, but seems valid.

--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path

Django
In reply to this post by Django
#19528: CachedFilesMixin does not rewrite rules for css selector with path
-------------------------------------+-------------------------------------
     Reporter:  mike@…               |                    Owner:  jnovinger
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.staticfiles  |                  Version:  1.4
     Severity:  Normal               |               Resolution:
     Keywords:  CachedFilesMixin     |             Triage Stage:  Accepted
  staticfiles                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by jnovinger):

 * owner:  nobody => jnovinger
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/077.14c04c105f24f7db4d02eb623203bda1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path

Django
In reply to this post by Django
#19528: CachedFilesMixin does not rewrite rules for css selector with path
-------------------------------------+-------------------------------------
     Reporter:  mike@…               |                    Owner:  jnovinger
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.staticfiles  |                  Version:  1.4
     Severity:  Normal               |               Resolution:
     Keywords:  CachedFilesMixin     |             Triage Stage:  Accepted
  staticfiles djbday                 |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by jnovinger):

 * keywords:  CachedFilesMixin staticfiles => CachedFilesMixin staticfiles
     djbday


--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/077.dc4070c3c0a9931e175dbec7a7b1bb07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path

Django
In reply to this post by Django
#19528: CachedFilesMixin does not rewrite rules for css selector with path
-------------------------------------+-------------------------------------
     Reporter:  mike@…               |                    Owner:  Jason
                                     |  Novinger
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.staticfiles  |                  Version:  1.4
     Severity:  Normal               |               Resolution:  invalid
     Keywords:  CachedFilesMixin     |             Triage Stage:  Accepted
  staticfiles djbday                 |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * status:  assigned => closed
 * resolution:   => invalid


Comment:

 This issue is not valid anymore because `CachedFilesMixin` and
 `CachedStaticFilesStorage` will be removed in Django 3.1 (see
 f1894bae3071da4ee577fc40ae61491f3e03d82c).

--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/077.4c32c2a42b8b56989d7425a84a752065%40djangoproject.com.