[Django] #19580: Unify reverse foreign key and m2m querying behavior

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
44 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[Django] #19580: Unify reverse foreign key and m2m querying behavior

Django
#19580: Unify reverse foreign key and m2m querying behavior
----------------------------------------------+--------------------
     Reporter:  akaariai                      |      Owner:  nobody
         Type:  Uncategorized                 |     Status:  new
    Component:  Database layer (models, ORM)  |    Version:  1.4
     Severity:  Normal                        |   Keywords:
 Triage Stage:  Unreviewed                    |  Has patch:  1
Easy pickings:  0                             |      UI/UX:  0
----------------------------------------------+--------------------
 Currently when querying unsaved reverse relations the behavior differs.

 Using model:
 {{{
 class Foo(models.Model):
     fk = models.ForeignKey('self', related_name='fk_rev')
     m2m = models.ManyToManyField('self')
 }}}
 and test case:
 {{{
 print(Foo().fk_rev.all())
 print(Foo().m2m.all())
 }}}

 We get [] from the first filter, but an error
 {{{
 ValueError: "<Foo: Foo object>" needs to have a value for field "from_foo"
 before this many-to-many relationship can be used.
 }}}
 from the second filter.

 So, m2m fields can't be filtered if the object isn't saved, but reverse fk
 fields can be filtered.

 There is a (slightly stale) patch for #17541 which makes fk fields and m2m
 fields work consistently. The changes in behavior are:
 {{{
 * Nullable many-to-many and foreign key relations will return an empty
   queryset when the relation field is null. For many-to-many this was
   previously an error (no change for foreign keys).

 * Trying to add objects to a foreign key relation when the relation field
   is null is now an error (no change for m2m).

 * Trying to use a relation of any kind when the object isn't saved is now
   an error (no change for m2m).
 }}}

 I think we can squeeze these changes in as bug-fixes. These are slight
 backwards compatibility changes, but to me it seems that almost always the
 changes will be visible only in code that isn't working as intended. If
 these are seen as something likely breaking working code, then I don't see
 any way to make the APIs consistent.

 The #17541 patch is available from:
 https://github.com/akaariai/django/compare/ticket_17541

--
Ticket URL: <https://code.djangoproject.com/ticket/19580>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m querying behavior

Django
#19580: Unify reverse foreign key and m2m querying behavior
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |                  Version:  master
    Component:  Database layer       |               Resolution:
  (models, ORM)                      |             Triage Stage:  Design
     Severity:  Normal               |  decision needed
     Keywords:                       |      Needs documentation:  0
    Has patch:  1                    |  Patch needs improvement:  1
  Needs tests:  0                    |                    UI/UX:  0
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by akaariai):

 * needs_better_patch:   => 1
 * needs_tests:   => 0
 * version:  1.4 => master
 * needs_docs:   => 0
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Design decision needed


Comment:

 Reviewing my own ticket as "DDN".

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m querying behavior

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m querying behavior
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |                  Version:  master
    Component:  Database layer       |               Resolution:
  (models, ORM)                      |             Triage Stage:  Accepted
     Severity:  Normal               |      Needs documentation:  0
     Keywords:                       |  Patch needs improvement:  1
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * stage:  Design decision needed => Accepted


Comment:

 Yes, it's better to error loudly on operations that can't work because the
 database didn't generate an id for the object yet.

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying (was: Unify reverse foreign key and m2m querying behavior)

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by timgraham):

 * easy:  0 => 1


Comment:

 I think this would allow removing the two lines added in
 a4c20ae85b40c49e28d1b2227208e4f00d7820df.

 Marking as "Easy pickings" since rebasing Anssi's original patch might not
 be too difficult.

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.c93c4c6c8527c6a46842efcf440a57fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:
         Type:                       |  ketanbhatt
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by ketanbhatt):

 * status:  new => assigned
 * owner:  nobody => ketanbhatt


Comment:

 I will create a new branch, and make the changes made in
 https://github.com/django/django/compare/master...akaariai:ticket_17541

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.38638a5c676cf6f0881074b16f060bf3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:
         Type:                       |  ketanbhatt
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by timgraham):

 Yes, you should
 [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /working-with-git/#rebasing-branches rebase the branch] and update the
 release notes for 1.11.

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.bea15cbb6143e2cc89bf7c68ed05bc9a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by timgraham):

 * owner:  ketanbhatt =>
 * status:  assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.217b881c57ac1c5705457961c5914c96%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by mscott250):

 Hi,

 I'm interested in contributing to Django and have been advised to start
 with some of the 'easy pickings' tasks. I've seen it's been unassigned and
 is still open, is this something I can pick up?

 Cheers,
 Michael

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.7df7b98a84561c5959ea5a98e599a9ef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:  akuzminov
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by akuzminov):

 * owner:   => akuzminov
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.29d2da6b6f0e7031567a534a0faf1b92%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:  akuzminov
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by timgraham):

 I left comments for improvement on the rebased
 [https://github.com/django/django/pull/7098 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.0e0a0f6f37ebbf9062dacb73228949ec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  akaariai             |                    Owner:  akuzminov
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by akuzminov):

 Thanks Tim, I'll add more tests next week

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.cdc1f4b4a738d17f70033dbf1dc2c60b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Olivier Tabone):

 * cc: olivier.tabone@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.9d0f6046565aa5d4606c810303913b9d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Olivier Tabone):

 added comments in the PR

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.dbb40f763dbcc6e769e0b22277d17ffa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.d1f878808095f81482c61685cbfc2da7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Ian Foote):

 * needs_better_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.284752718ec69befed4e8665f48d0bcb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.1d77727f44ce454ebab305ec8f73dbcc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by eadhina):

 Hey guys, is this ticket still need a fix ?

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.9607061930d602b10ab80c2b05b73180%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  Andrey
         Type:                       |  Kuzminov
  Cleanup/optimization               |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by John McCann):

 Hi there, I was also wondering if further work is needed? From Tim's final
 comment in the pull request, it seems that most of the changes from Ansi's
 patch still haven't been updated in master. Thanks

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.50077bcb38f4e36e5397a4d38ad384fc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  (none)
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * status:  assigned => new
 * owner:  Andrey Kuzminov => (none)


Comment:

 I think someone else could pick this up considering we haven't heard from
 Andrey in a while.

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.44e2d3e42ac266e4c43d28c937ca7475%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

Django
In reply to this post by Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
     Reporter:  Anssi Kääriäinen     |                    Owner:  (none)
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Lander Kerbey):

 Newbie here, but I've begun reading through this problem and would like to
 take a crack at it. Andrey's pull request seems most of the way there, and
 if the comments remain valid that gives me a starting point. Thoughts?

--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:18>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.a0012d9f55e29b1540a2036d3c8b1aa2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
123