[Django] #19878: Not all class based views push self.kwargs to context

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #19878: Not all class based views push self.kwargs to context

Django
#19878: Not all class based views push self.kwargs to context
-------------------------------+--------------------
     Reporter:  void           |      Owner:  nobody
         Type:  Bug            |     Status:  new
    Component:  Generic views  |    Version:  master
     Severity:  Normal         |   Keywords:
 Triage Stage:  Unreviewed     |  Has patch:  0
Easy pickings:  0              |      UI/UX:  0
-------------------------------+--------------------
 Only TemplateView pushes self.kwargs to the context. ListView does not, I
 yet have to check others.
 This is inconsistency and, I think, it should be fixed.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Design
    Has patch:  0                    |  decision needed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by carljm):

 * needs_docs:   => 0
 * stage:  Unreviewed => Design decision needed
 * type:  Bug => New feature
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 Setting this DDN pending comment from someone who uses class-based views.
 Seems like a new feature rather than a bug, in any case.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  closed
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Jonas Svensson <jonas.s.svensson@…>):

 * status:  new => closed
 * keywords:   => django-sprint
 * has_patch:  0 => 1
 * resolution:   => fixed


Comment:

 https://github.com/django/django/pull/753

 The CBV:

 * BaseDetailView
 * ProcessFormView
 * BaseListView

 Did not push the kwargs into the context

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by void):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 The ticket is not fixed until patch in merged into the django. Please
 don't set status to closed until it's not closed.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by aaugustin):

 This can be backwards incompatible in keys in `kwargs` clash with keys in
 the output of `get_context_data()`.

 The current behavior might be for backwards compatibility with the now-
 removed function-based generic views. Maybe this was discussed on django-
 developers?

 This would need docs (release notes + check if the CBV docs need to be
 updated), and tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  1                    |      Needs documentation:  1
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  1                    |      Needs documentation:  1
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by mjtamlyn):

 * cc: marc.tamlyn@… (added)


Comment:

 I am strongly the other way on this issue - I think the feature is wrong
 in `TemplateView` and should be deprecated.

 For example, it means that it's hard to have `context_object_name` and
 `slug_url_kwarg` the same - whether you get the object or the slug would
 be rather arbitrary.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  closed
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  1                    |      Needs documentation:  1
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by jacob):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Agreed with mjtamlyn, so marking this wontfix.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  closed
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  1                    |      Needs documentation:  1
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by mjtamlyn):

 Jacob - what's your opinion on taking the deprecation the other way - this
 one-off behaviour of `TemplateView` has bitten me before. Personally I'd
 like the views to be consistently *without* this feature.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------------+-------------------------------------
     Reporter:  void                 |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  1                    |      Needs documentation:  1
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * status:  closed => new
 * resolution:  wontfix =>


--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Not all class based views push self.kwargs to context

Django
In reply to this post by Django
#19878: Not all class based views push self.kwargs to context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by aaugustin):

 * needs_docs:  1 => 0
 * has_patch:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Design decision needed => Accepted


Comment:

 IIRC TemplateView works like this for backwards-compatibility with the
 (now defunct) function-based generic views.

 It would make sense to normalize it now, assuming we can figure out a
 deprecation path.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context (was: Not all class based views push self.kwargs to context)

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Marcin Szamotulski <mszamot@…>):

 * cc: mszamot@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.90076b15676818c94077da4c9d0dc290%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by mjtamlyn):

 Hmm, I know I'd done something at some point using these views which had
 bitten me, but I can't remember what it was. This is near impossible to
 deprecate nicely and probably shouldn't be that big a deal.

 That said, it didn't exist before 1.5 in its current form - the way these
 arguments are used was (backwardsly incompatibly) changed then anyway.
 Personally I'd like to just remove it as it "feels wrong", but whether
 that is a good idea is another question.

 '''History lesson'''

 Django 1.2 had `direct_to_template` which would pass through URL kwargs as
 an object called `params` into the context
 Django 1.3 & 1.4 continued this pattern in the new `TemplateView`
 Django 1.5 changed `TemplateView` to place the arguments directly into the
 context (and deprecated `direct_to_template`)

 My personal feeling is that using URLconf kwargs directly in a view is a
 bad pattern, but it is a historical Django pattern. This, and the ability
 to customise CBVs using the `as_view()` call, are the remaining parts of
 it.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.31e281f7051645b8fdd0c5d8228001c4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by loic84):

 I ran into the same problem as @mjtamlyn with `TemplateView`; and I also
 think that having the URL `kwargs` directly in the `context_data` is an
 anti pattern.

 The anti pattern added to the discrepancy between the different views is
 IMO a problem big enough to warrant a documented backward incompatible
 change.

 I tried to think of a transparent deprecation cycle, but what I found was
 at best fragile and hackish.

 One option would be to ask people to set a `kwargs_to_context = False`
 argument on their `TemplatView` to get the "new" behavior and therefore
 opt out from the `DeprecationWarning`.

 Thoughts?

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.3aa6d740c7db459fe2f9e62dcfc6f3c4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by timo):

 I'm not much of a user of CBVs but that deprecation plan sounds like it
 would work.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.db5289760f5fd210618aa99e0d1f3f2d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by cjerdonek):

 Note that there is a distinction between //passing// `**kwargs` to
 `get_context_data()` and having `get_context_data()` //return//
 `**kwargs`.

 Personally, I would favor `TemplateView` continuing to pass `**kwargs` to
 `get_context_data()` even if its return value is changed by default not to
 include `kwargs`.  This would keep overriding `get_context_data()` simple
 because you can simply access `**kwargs` in the method without having to
 decide between `**kwargs` and `self.kwargs`.

 For consistency, I would like it if all generic views passed the full
 view's keyword arguments to `get_context_data()`.  Some classes like
 `ProcessFormView` restrict what is passed to `get_context_data()`, which
 was surprising to me because then `**kwargs` for the method differs from
 `self.kwargs`.  I just opened #21964 which is about this issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.4d2c2846eb1b81de2914684ef1f4d1c1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------+------------------------------------
     Reporter:  void           |                    Owner:  nobody
         Type:  New feature    |                   Status:  new
    Component:  Generic views  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  django-sprint  |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by cjerdonek):

 * cc: chris.jerdonek@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.9e80f8a62b555d47d85f42daff7fbb31%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------------+-------------------------------------
     Reporter:  Alexey Boriskin      |                    Owner:  Adam
                                     |  (Chainz) Johnson
         Type:  New feature          |                   Status:  assigned
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  1
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Adam (Chainz) Johnson):

 * owner:  nobody => Adam (Chainz) Johnson
 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * status:  new => assigned
 * needs_docs:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:18>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.299feb5133334855ff6f4883a8291396%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #19878: Stop TemplateView automatically passing kwargs into the context

Django
In reply to this post by Django
#19878: Stop TemplateView automatically passing kwargs into the context
-------------------------------------+-------------------------------------
     Reporter:  Alexey Boriskin      |                    Owner:  Adam
                                     |  (Chainz) Johnson
         Type:  New feature          |                   Status:  assigned
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  django-sprint        |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  1
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Adam (Chainz) Johnson):

 * cc: Adam (Chainz) Johnson (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/19878#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/062.c6b045b905a9ac56db517e3b3d59d8e2%40djangoproject.com.