[Django] #23718: TEST_MIRROR setting doesn't work as expected

classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Django] #23718: TEST_MIRROR setting doesn't work as expected

Django
#23718: TEST_MIRROR setting doesn't work as expected
-----------------------------------+-----------------------------
     Reporter:  coagulant          |      Owner:  nobody
         Type:  Bug                |     Status:  new
    Component:  Testing framework  |    Version:  1.7
     Severity:  Normal             |   Keywords:  replica testing
 Triage Stage:  Unreviewed         |  Has patch:  0
Easy pickings:  0                  |      UI/UX:  0
-----------------------------------+-----------------------------
 TEST_MIRROR promises "connection to slave will be redirected to point at
 default. As a result, writes to default will appear on slave"
 I've set up a minimum django project (using postgres backed) to
 demonstrate behavior.

 {{{

     def test_fixture(self):
         MyModel.objects.using('default').create(name=1)
         MyModel.objects.using('slave').create(name=2)
         MyModel.objects.using('slave').create(name=3)
         self.assertEqual(list(map(repr,
 MyModel.objects.using('default').all())),
                          list(map(repr,
 MyModel.objects.using('slave').all())))
 }}}

 Both lists should be equal, because replica queries should be hitting
 default instead.
 It appears not to be the case for Django>=1.4 up to latest 1.7.1 (but
 actually passes against 1.3.7)

 {{{
 AssertionError: Lists differ: ['<MyModel: 1>', '<MyModel: 2>... !=
 ['<MyModel: 2>', '<MyModel: 3>...

 First differing element 0:
 <MyModel: 1>
 <MyModel: 2>

 First list contains 1 additional elements.
 First extra element 2:
 <MyModel: 3>

 - ['<MyModel: 1>', '<MyModel: 2>', '<MyModel: 3>']
 ?             ^               ----------------

 + ['<MyModel: 2>', '<MyModel: 3>']
 ?             ^
 }}}

 Here is a project I used to test: https://github.com/coagulant/test_mirror

--
Ticket URL: <https://code.djangoproject.com/ticket/23718>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.f211cf312c0f9d8458085f5c81e1cf45%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected

Django
#23718: TEST_MIRROR setting doesn't work as expected
-----------------------------------+--------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Unreviewed
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+--------------------------------------
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 It would be quite helpful if you could convert your test to one for
 Django's test suite and then bisect to determine the commit in Django that
 introduced the regression.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.579fee41550ae1f1dfa29bc12eaa1b74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected
-----------------------------------+--------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Unreviewed
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+--------------------------------------

Comment (by coagulant):

 I've run git bisect, and first commit with regression happened to be:
 [https://github.com/django/django/commit/905e33f84a1a10e4f0183d879c52076ef876fc3b
 905e33f84a1a10e4f0183d879c52076ef876fc3b], which is related to #16885

 Here is a log of my bisect:
 https://gist.github.com/coagulant/d04b3e729b851784a93a

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.b6a7337cf987d243bcc6d2cffec015b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests) (was: TEST_MIRROR setting doesn't work as expected)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


Comment:

 I haven't verified the issue, but I noticed there are no tests for
 `TEST['MIRROR']` (renamed on master) so we should at least add some. Also
 the test in the "regression commit" seems to be gone -- not sure if its
 removal was intentional or not.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.5df9b9d38cb6a5e370f4c958cbcb7307%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by Atala):

 Ran into the same issue, I think both the old (TEST_MIRROR) and new (TEST:
 {MIRROR:) settings are not working. I had the issue running raw sql with
 the connection cursor.

 I am new in this part of the codebase & in databases connections, so I am
 not really sure what's going on. In this gist:
 https://gist.github.com/Atala/d5420ac426c79b45d4db , it's clear that the
 two connections returned are not the same object (they should have same ID
 no?)  but are pointing to the same DB name. However a SELECT statement
 will work only on the 'default' db, a SELECT against 'prestashop' will
 return nothing (but the tables are correctly created).

 I would be glad to help if you had some hints,

 Aloïs

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.170399f086ed31baa9315fd2c478eb5e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by Atala):

 Replying to [comment:4 Atala]:
 > I deleted my comment, I was running the tests with django_nose test
 runner - just noticed it today. Still having issues with mirroring during
 tests, I will try to investigate more later on.
 >
 > Aloïs

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.bc273ba6ff83a092ede79b9aa144444e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by shaib):

 The behavior in the bug description is sort-of expected, because of
 transactions (`default` and `slave` are the same database -- in the test
 project, they are defined this way even regardless of `TEST_MIRROR` -- but
 accessed through different connections, and so, separate transactions).

 I'm saying sort-of expected because it seems the test is running in a
 transaction on `default` but not on `slave`, which is a little surprising
 -- but not the problem claimed.

 I don't think we want to force test-cases to run each test in transactions
 on all databases -- I'm not sure that even makes sense; but we should
 probably document that tests using more than one database should be
 `TransactionTestCase`s.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.fedf22e95f318b5e93a3c5de0ae1cc95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by harrykao):

 Is it possible to have the mirrors share a connection? Using
 `TransactionTestCase` has the additional disadvantage of preventing
 multiprocessed test runs, which works fine when each test runs in a
 transaction.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.b3221cd7efe2f557582d45042fad6bed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by yellottyellott):

 I just ran into this as well. Based on the documentation, I expected to
 set

 {{{
 DATABASES = {
     'default': {
         ...
     },
     'replica': {
         ...
         'TEST_MIRROR': 'default',
         # 'TEST': {'MIRROR': 'default'},  # I tried this too.
     }
 }
 }}}

 and have my tests read from replica and write to default, which should be
 the same database and act as if I had just one database defined as
 `default`.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.fbebfb0a636557198fe86dd68cb9f09c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by aaugustin):

 I just rediscovered that test mirrors require `TransactionTestCase`.

 I'm wondering if it would be possible to share the database connection
 instead of having two connections with the same parameters.

 If that doesn't work, we can document this limitation instead.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.3ac5f6013776b33e61883f0d682192e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  coagulant          |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by asser):

 Just ran into this, but with raw queries instead. Using the connection
 directly does not work even with {{{TransactionTestCase}}}.

 So for now I'm using this hacky workaround:

 {{{
 #!python
 from django.db import connections

 class ReplicationTestCase(TestCase):
     """
     Redirect raw queries to the replica, ie.

         from django.db import connections

         cursor = connections['replica'].cursor()
         cursor.execute(...)  # Is run directly on master in tests
     """
     def setUp(self):
         super(ReplicationTestCase, self).setUp()
         connections['replica']._orig_cursor =
 connections['replica'].cursor
         connections['replica'].cursor = connections['master'].cursor

     def tearDown(self):
         connections['replica'].cursor =
 connections['replica']._orig_cursor
         super(ReplicationTestCase, self).tearDown()
 }}}

 As an added benefit it works for model managers too even though I'm not
 using {{{TransactionTestCase}}} indicating that the connection might be
 able to be shared in a similar way?

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.82e7266cd54e680cdbecaf38cf3d9dfe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  Ilya Baryshev      |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by Kyle Agronick):

 Is this ever going to be fixed? Setting the mirror should just copy the
 cursor so no matter where the slave DB is called it redirects to the
 master.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.52d1595162f827b413bd5e219030adbc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  Ilya Baryshev      |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by Tim Graham):

 It will be fixed when someone submits a patch and another person reviews
 it.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.9ace940d64c1a6be25d3aec557e541ff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-----------------------------------+------------------------------------
     Reporter:  Ilya Baryshev      |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.7
     Severity:  Normal             |               Resolution:
     Keywords:  replica testing    |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by eng. Ilian Iliev):

 I have created a small patch, the PR is here
 https://github.com/django/django/pull/9603

 The solution I went for is that when the `MIRROR` is specified then the
 mirror uses the same connection as the mirrored one.
 If the tests look a bit redundant please let me know.

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.34b5377500ad53cb41d7cb0bea48687c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-------------------------------------+-------------------------------------
     Reporter:  Ilya Baryshev        |                    Owner:  eng.
                                     |  Ilian Iliev
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  replica testing      |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by eng. Ilian Iliev):

 * status:  new => assigned
 * owner:  nobody => eng. Ilian Iliev


--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.bb3bd6475bce54c18b8f3afd497f3fdd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-------------------------------------+-------------------------------------
     Reporter:  Ilya Baryshev        |                    Owner:  eng.
                                     |  Ilian Iliev
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  replica testing      |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Asif Saifuddin Auvi):

 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.b1fb579411b4ee16e32a70fd0cd9a385%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-------------------------------------+-------------------------------------
     Reporter:  Ilya Baryshev        |                    Owner:  eng.
                                     |  Ilian Iliev
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  replica testing      |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 Comments on PR

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.82d47175eb8f7d7e0e2c0c9efa056743%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-------------------------------------+-------------------------------------
     Reporter:  Ilya Baryshev        |                    Owner:  eng.
                                     |  Ilian Iliev
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  replica testing      |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by eng. Ilian Iliev):

 Patch has been improved - https://github.com/django/django/pull/9603

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.300e865b4ecd34532e99a12bd9f584df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-------------------------------------+-------------------------------------
     Reporter:  Ilya Baryshev        |                    Owner:  eng.
                                     |  Ilian Iliev
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  replica testing      |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:18>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.ee73a396ce33567ae109226b3268b81c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #23718: TEST_MIRROR setting doesn't work as expected (and has no tests)

Django
In reply to this post by Django
#23718: TEST_MIRROR setting doesn't work as expected (and has no tests)
-------------------------------------+-------------------------------------
     Reporter:  Ilya Baryshev        |                    Owner:  eng.
                                     |  Ilian Iliev
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  replica testing      |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson):

 Question from PR:

 The PR currently uses mocks in the tests, but it's **much** simpler (for
 the current test and presumably into the future) and much clearer to just
 declare an extra `replica` alias with the `TEST["MIRROR"]` setting.

 This second approach would require adjustments to test settings for
 Jenkins, the Django-Box VM and all devs' settings running against other
 DBs.

 So the question is can we make that change?

--
Ticket URL: <https://code.djangoproject.com/ticket/23718#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.e184e98e29a51316781c5e341b7a88ee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
12