[Django] #26601: DEP5 implementation: Improved middleware

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #26601: DEP5 implementation: Improved middleware

Django
#26601: DEP5 implementation: Improved middleware
-----------------------------------------+------------------------
               Reporter:  timgraham      |          Owner:  nobody
                   Type:  New feature    |         Status:  new
              Component:  HTTP handling  |        Version:  master
               Severity:  Normal         |       Keywords:
           Triage Stage:  Accepted       |      Has patch:  0
    Needs documentation:  0              |    Needs tests:  0
Patch needs improvement:  0              |  Easy pickings:  0
                  UI/UX:  0              |
-----------------------------------------+------------------------
 The existing Django "middleware" abstraction suffers from a lack of strict
 layering and balanced in/out calls to a given middleware. This DEP
 proposes an improved abstraction for wrapping the request cycle in layered
 pre-view and post-view actions.

 [https://github.com/django/deps/blob/master/draft/0005-improved-
 middleware.rst DEP]

 [https://groups.google.com/d/topic/django-
 developers/8LMJ44KAxWI/discussion django-developers discussion]

--
Ticket URL: <https://code.djangoproject.com/ticket/26601>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.6ea066e86383370ba9b0eb56d027017f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
#26601: DEP5 implementation: Improved middleware
-------------------------------+-------------------------------------
     Reporter:  timgraham      |                    Owner:  timgraham
         Type:  New feature    |                   Status:  assigned
    Component:  HTTP handling  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+-------------------------------------
Changes (by timgraham):

 * status:  new => assigned
 * owner:  nobody => timgraham
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/6501 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.534ccd613732231b6684889b520675e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  timgraham            |                    Owner:  timgraham
         Type:  New feature          |                   Status:  assigned
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


Comment:

 Got an LGTM from Carl; awaiting technical board approval of the DEP.

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.65d162e20fe9d25e667032a908dfce6f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  timgraham            |                    Owner:  timgraham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In 05c888ffb843ba3eff06cd07b3cef5bbb513a54f:

 Refs #26601 -- Refactored BaseHandler to prepare for new-style middleware.

 In 9baf692a58de78dba13aa582098781675367c329:

 Fixed #26601 -- Improved middleware per DEP 0005.

 In ece4d24f8e494129c098868fa792400937941fab:

 Refs #26601 -- Deprecated old-style middleware.

 In 354acd04af524ad82002b903df1189581c51cabe:

 Refs #26601 -- Added a warning if both MIDDLEWARE AND MIDDLEWARE_CLASSES
 are set.

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.8c17d6e6502c0a6f2e45c4a1958b1161%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  timgraham            |                    Owner:  timgraham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Carl Meyer <carl@…>):

 In [changeset:"7d1b69dbe7f72ac04d2513f0468fe2146231b286" 7d1b69db]:
 {{{
 #!CommitTicketReference repository=""
 revision="7d1b69dbe7f72ac04d2513f0468fe2146231b286"
 Refs #26601 -- Improved backwards-compatibility of DEP 5 middleware
 exception handling.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.a3b27f1b1cd36599685476f1a4189c90%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  timgraham            |                    Owner:  timgraham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"69de988f9237fe978c5fca363ca2d2622f8e2ccd" 69de988f]:
 {{{
 #!CommitTicketReference repository=""
 revision="69de988f9237fe978c5fca363ca2d2622f8e2ccd"
 [1.10.x] Refs #26601 -- Improved backwards-compatibility of DEP 5
 middleware exception handling.

 Backport of 7d1b69dbe7f72ac04d2513f0468fe2146231b286 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.ad311ce843aab472e8a3179b80e1f43e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Tim
                                     |  Graham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"d334f46b7a080fd3eb720141c19b37b10704a352" d334f46b]:
 {{{
 #!CommitTicketReference repository=""
 revision="d334f46b7a080fd3eb720141c19b37b10704a352"
 Refs #26601 -- Removed support for old-style middleware using
 settings.MIDDLEWARE_CLASSES.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7100cdb2ef868b06336d3a7b2ee1df9a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Tim
                                     |  Graham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"6192bffb130132461e55e5fe7a7eaaa9a166d08f" 6192bff]:
 {{{
 #!CommitTicketReference repository=""
 revision="6192bffb130132461e55e5fe7a7eaaa9a166d08f"
 Refs #26601 -- Removed obsolete system check for MIDDLEWARE_CLASSES
 setting.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.0a194dcb6cb146ef6401736c4f9fda79%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Tim
                                     |  Graham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"d71497bb249a2c3ffec41e99089f5ae8e575f2d3" d71497b]:
 {{{
 #!CommitTicketReference repository=""
 revision="d71497bb249a2c3ffec41e99089f5ae8e575f2d3"
 Refs #26601 -- Used new-style middlewares in documentation.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.ff24d4bf3d7d4b8d5826974b2dcdf8a4%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Tim
                                     |  Graham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"1319124aa9b997cb73cc6e8097f9d34e771d1867" 1319124]:
 {{{
 #!CommitTicketReference repository=""
 revision="1319124aa9b997cb73cc6e8097f9d34e771d1867"
 [3.0.x] Refs #26601 -- Used new-style middlewares in documentation.

 Backport of d71497bb249a2c3ffec41e99089f5ae8e575f2d3 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7b1facdf316016da40f18710ff0ecf80%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Tim
                                     |  Graham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"29d2f5a66212af91f93edb47df07982f92b4ac5f" 29d2f5a6]:
 {{{
 #!CommitTicketReference repository=""
 revision="29d2f5a66212af91f93edb47df07982f92b4ac5f"
 [2.2.x] Refs #26601 -- Used new-style middlewares in documentation.

 Backport of d71497bb249a2c3ffec41e99089f5ae8e575f2d3 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.1551762dacb32d4cdfab89c434c2b217%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #26601: DEP5 implementation: Improved middleware

Django
In reply to this post by Django
#26601: DEP5 implementation: Improved middleware
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Tim
                                     |  Graham
         Type:  New feature          |                   Status:  closed
    Component:  HTTP handling        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"0315c18fe170b1b611b7d10b5dde2f196b89a7e0" 0315c18f]:
 {{{
 #!CommitTicketReference repository=""
 revision="0315c18fe170b1b611b7d10b5dde2f196b89a7e0"
 Refs #26601 -- Removed obsolete workarounds for MIDDLEWARE_CLASSES
 setting.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26601#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.d0f90fb9abb97a4b4e81d33bfbdbf3d9%40djangoproject.com.