[Django] #27921: Documentation of make_aware() with is_dst is misleading

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
               Reporter:  Kevin      |          Owner:  nobody
  Christopher Henry                  |
                   Type:  Bug        |         Status:  new
              Component:             |        Version:  master
  Documentation                      |
               Severity:  Normal     |       Keywords:
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 A recent [http://stackoverflow.com/questions/42399438/django-make-aware-
 usage/42407744 StackOverflow question] prompted me to look into what
 `make_aware()` does with non-existent datetimes.

 The
 [https://docs.djangoproject.com/en/dev/ref/utils/#django.utils.timezone.make_aware
 documentation] says:

 > Setting `is_dst` to `True` or `False` will avoid the exception by moving
 the hour backwards or forwards by 1 respectively. For example,
 `is_dst=True` would change a nonexistent time of 2:30 to 1:30 and
 `is_dst=False` would change the time to 3:30.

 It appears that pytz in fact keeps the wall-clock time of 2:30 the same,
 and instead shifts the timezone to make the datetime valid.

 I'm not sure if it's better to describe what pytz does more precisely, or
 just to leave out that degree of detail (since pytz's documentation is
 itself not very precise on this point).

--
Ticket URL: <https://code.djangoproject.com/ticket/27921>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/050.26042e9a2ecd0d123909424a2126c46d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * cc: Josh Smeaton (added)


Comment:

 Josh, you authored that text in 143255c8bbefe03ff755d7859f029f0bc7a552aa.
 Does the analysis in this ticket appear correct?

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.60f309cee1c99d394337e4f78d6f4743%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Aymeric Augustin):

 * stage:  Unreviewed => Accepted


Comment:

 The sentence you quoted doesn't totally make sense to me, I support
 rewriting it.

 AFAIK (but I didn't double check), `is_dst` allows you to disambiguate
 ambiguous datetimes: you can pick the first or the second 2:30am when it
 happens twice.

 However it doesn't help with non existing local time, when 2:30 never
 happens. (If it does that's super surprising and warrants even more docs).

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.6983d382579ee80b16fbccbf35f015b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Kevin Christopher Henry):

 pytz does actually use `is_dst` to avoid the `NonExistentTimeError` (see
 the linked question for some console tests). Though I agree, Aymeric, that
 that usage seems less intuitive than in the `AmbiguousTimeError` case.

 I wonder if this calls for ''less'' documentation rather than more. The
 problem is that we're relying on a third-party library who's behavior is
 not specified. The pytz docs imply that using `is_dst` will avoid the
 error, but they don't specify whether that's done by shifting the wall-
 clock time (as currently documented by Django) or by shifting the timezone
 offset (as appears to actually be the case).

 Would it be sufficient to say:

 > The `pytz.NonExistentTimeError` exception is raised if you try to make
 `value` aware during a DST transition such that the time never occurred
 (when entering into DST). Setting `is_dst` to `True` or `False` will avoid
 the exception by moving the time backwards or forwards by 1 hour
 respectively.

 That's really the most you can say based on pytz's documentation.

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.57ff3e63306bb0de820e7395af6e2c07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Josh Smeaton):

 I don't think we should be too concerned about the wording of the `pytz`
 documentation. We should aim to provide our own docs that makes the most
 sense for our users. In that regard, perhaps it is worth clarifying the
 documentation in some way. I'm not exactly sure what that should be
 though. When I implemented this change, I was also confused about how pytz
 was representing time during ambiguous and non-existent periods, so I'm
 not surprised that users are also somewhat confused.

 Just quickly, the currently implemented behaviour is correct. Either side
 of the transition round trips through the database and via UTC to the
 correct moment in time. But it doesn't sound like that bit is in question.
 I'd also readily admit that the use case for `is_dst=True` for non
 existent times is probably very little - I can't think of one.

 Even in the ambiguous case, pytz represents the time as a shift in the
 timezone.

 {{{
 In [65]: CET = pytz.timezone("Europe/Paris")

 In [66]: ambiguous = datetime.datetime(2015, 10, 25, 2, 30)

 In [67]: std = timezone.make_aware(ambiguous, timezone=CET, is_dst=False)
     ...: dst = timezone.make_aware(ambiguous, timezone=CET, is_dst=True)
     ...:

 In [68]: std
 Out[68]: datetime.datetime(2015, 10, 25, 2, 30, tzinfo=<DstTzInfo
 'Europe/Paris' CET+1:00:00 STD>)

 In [69]: dst
 Out[69]: datetime.datetime(2015, 10, 25, 2, 30, tzinfo=<DstTzInfo
 'Europe/Paris' CEST+2:00:00 DST>)
 }}}

 The representation is an adjustment in the timezone, but the logical
 result is a shift 1 hour backwards or 1 hour forwards in the *moment* of
 time. Neither Ambiguous or NonExistent modify the hour or minute
 accessible on the datetime instance. But if you save the result and fetch
 it, or round trip it through UTC, then the hour on the returned datetime
 object *does* change.

 Is it important to tell users that the time change is *represented* by a
 timezone shift? Conceptually, adjusting the hour is an easier concept to
 grasp even if the timezone offset is actually the thing changing in the
 current representation.

 To further complicate things:

 {{{

 # Equivalences

 In [32]: tz = pytz.timezone('America/Sao_Paulo')
     ...: dt = datetime.datetime(2017, 10, 15, 0)
     ...: dt_plus_one = datetime.datetime(2017, 10, 15, 1)
     ...: dt_minus_one = datetime.datetime(2017, 10, 14, 23)
     ...:

 In [33]: std = timezone.make_aware(dt, timezone=tz, is_dst=False)

 In [34]: dst = timezone.make_aware(dt, timezone=tz, is_dst=True)

 In [35]: after = timezone.make_aware(dt_plus_one, timezone=tz)

 In [36]: before = timezone.make_aware(dt_minus_one, timezone=tz)

 In [52]: dt_plus_one_aware = timezone.make_aware(dt_plus_one, timezone=tz)

 In [53]: dt_plus_one_aware
 Out[53]: datetime.datetime(2017, 10, 15, 1, 0, tzinfo=<DstTzInfo
 'America/Sao_Paulo' BRST-1 day, 22:00:00 DST>)

 In [54]: aware_minus = dt_plus_one_aware - timedelta(hours=1)
 Out[54]: datetime.datetime(2017, 10, 15, 0, 0, tzinfo=<DstTzInfo
 'America/Sao_Paulo' BRST-1 day, 22:00:00 DST>)

 In [60]: dst
 Out[60]: datetime.datetime(2017, 10, 15, 0, 0, tzinfo=<DstTzInfo
 'America/Sao_Paulo' BRST-1 day, 22:00:00 DST>)

 In [61]: before
 Out[61]: datetime.datetime(2017, 10, 14, 23, 0, tzinfo=<DstTzInfo
 'America/Sao_Paulo' BRT-1 day, 21:00:00 STD>)

 In [62]: aware_minus
 Out[62]: datetime.datetime(2017, 10, 15, 0, 0, tzinfo=<DstTzInfo
 'America/Sao_Paulo' BRST-1 day, 22:00:00 DST>)

 In [63]: dst == before == aware_minus
 Out[63]: True

 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.a3e6f9923fbb76236c89a3a63b003873%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Josh Smeaton):

 Kevin, your proposed wording is less ambiguous (and more correct), but I
 think having actual examples are useful in conceptualising the time shift
 because in the case of NonExistent times, it's not really obvious. I'm not
 sure how to do this without confusing at least someone - it's a confusing
 topic.

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.d2db73062c280bdb756c2a4e22c26e02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Aymeric Augustin):

 Sorry for the less than useful first comment :-( What about the following
 clarification:

 > For example, is_dst=True would change a nonexistent time of 2:30 to 1:30
 '''pre-transition''' and is_dst=False would change the time to 3:30
 '''post-transition'''.

 We could also add the following sentence to prevent people from wasting
 their time trying to understand this calculation.

 > This change is arbitrary. It doesn't represent a meaningful conversion.
 It merely modifies the value in order to avoid an exception.'''

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.b06ab008e17ab05e5ec41d9eca1bc32c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Josh Smeaton):

 I'm not too keen on the second note you've got there. Here's a trivial but
 understandable example where you would want make_aware to just fix the
 issue.

 {{{
 start = datetime.datetime(2017, 10, 14, 23, 0)  # pretend this is just
 `datetime.now()
 finish_at = start + timedelta(hours=1)

 # whoops, we're in local time, but we use USE_TZ so we should make it
 aware before saving to database
 start = timezone.make_aware(start, timezone=tz)
 finish_at = timezone.make_aware(finish_at, timezone=tz)  # boom
 }}}

 You could certainly make the argument that this is a bug in the program
 behaviour. You should be working with timezones throughout - not just when
 saving to the database. Also, you'd have to be aware of the `is_dst` flag
 in the first place. Chances are if you're aware of it, then you're also
 just working with timezones to begin with. If you provide the wrong
 argument to is_dst, then `finish_at == start`, and you'd want to flip the
 flag for non-existent, and ambiguous times. I think I've just listed about
 3 examples of why this is a bad idea, almost proving Aymerics point :)

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.e9e08e2b3268ffcc4e3258d6d3728d0b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  nobody
  Henry                              |
         Type:  Bug                  |                   Status:  new
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Kevin Christopher Henry):

 We can definitely all agree that this is a hard subject to document
 concisely and accurately.

 I think the current version is just too concise to be acceptably accurate.
 It gives the impression that the wall clock time changes, and by not
 specifying the time zone of the 1:30 and 3:30 risks leaving the impression
 that they differ by two hours instead of one. Here's an attempt at
 avoiding that while keeping the example (at the cost of being a bit more
 verbose):

 > The `pytz.NonExistentTimeError` exception is raised if you try to make
 `value` aware during a DST transition such that the time never occurred.
 For example, if the 2:00 hour is skipped during a DST transition, trying
 to make 2:30 aware in that time zone will lead to an exception. To avoid
 that you can use `is_dst` to specify how `make_aware` should interpret
 such a non-existing time. If `True` then the above time would be
 interpreted as 2:30 DST time (equivalent to 1:30 local time). Conversely,
 if `False` the time would be interpreted as 2:30 standard time (equivalent
 to 3:30 local time).

 (Coincidentally, we're passing through a block of NonExistent time here in
 `America/New_York` as I write this...)

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.f1bdbcd0b6dda8425f2d98eb489e06ca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  paqman85
  Henry                              |
         Type:  Bug                  |                   Status:  assigned
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by paqman85):

 * owner:  nobody => paqman85
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.d667bb44fbbb2f453ed7226c91f8124f%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  paqman85
  Henry                              |
         Type:  Bug                  |                   Status:  assigned
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by paqman85):

 This ticket has been opened for quite a while so I thought I'd make the
 changes suggested by Kevin Christopher Henry, which does clarify the issue
 without overcomplicating it (in my opinion).

 Changes noted below:

     The '''pytz.NonExistentTimeError''' exception is raised if you try to
 make '''value''' aware during a DST transition such that the time never
 occurred. For example, if the 2:00 hour is skipped during a DST
 transition, trying to make 2:30 aware in that time zone will lead to an
 exception. To avoid that you can use '''is_dst''' to specify how
 make_aware should interpret such a non-existing time. If '''is_dst=True'''
 then the above time would be interpreted as 2:30 DST time (equivalent to
 1:30 local time). Conversely, if '''is_dst=False''' the time would be
 interpreted as 2:30 standard time (equivalent to 3:30 local time).

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.e66de3a0a665e90e228736eb6a3a04e4%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  Glenn
  Henry                              |  Paquette
         Type:  Bug                  |                   Status:  assigned
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11822 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.98d01167df3e296ab54f312697765993%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  Glenn
  Henry                              |  Paquette
         Type:  Bug                  |                   Status:  closed
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c2678e49759e5c4c329bff0eeca2886267005d21" c2678e49]:
 {{{
 #!CommitTicketReference repository=""
 revision="c2678e49759e5c4c329bff0eeca2886267005d21"
 Fixed #27921 -- Clarified usage of make_aware() with is_dst argument.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.341d8e8c2bd651dfbf0981937712e639%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  Glenn
  Henry                              |  Paquette
         Type:  Bug                  |                   Status:  closed
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"311177d5d1cf0e372492896ee9a084f0fc39e569" 311177d5]:
 {{{
 #!CommitTicketReference repository=""
 revision="311177d5d1cf0e372492896ee9a084f0fc39e569"
 [3.0.x] Fixed #27921 -- Clarified usage of make_aware() with is_dst
 argument.

 Backport of c2678e49759e5c4c329bff0eeca2886267005d21 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.22c34587a3e669e7729939692048c9cd%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #27921: Documentation of make_aware() with is_dst is misleading

Django
In reply to this post by Django
#27921: Documentation of make_aware() with is_dst is misleading
-------------------------------------+-------------------------------------
     Reporter:  Kevin Christopher    |                    Owner:  Glenn
  Henry                              |  Paquette
         Type:  Bug                  |                   Status:  closed
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"b1eea8a73a4fcf13844559e24d147287aafae994" b1eea8a7]:
 {{{
 #!CommitTicketReference repository=""
 revision="b1eea8a73a4fcf13844559e24d147287aafae994"
 [2.2.x] Fixed #27921 -- Clarified usage of make_aware() with is_dst
 argument.

 Backport of c2678e49759e5c4c329bff0eeca2886267005d21 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27921#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.ac8390ee07a50fdcad0cc4d551908b73%40djangoproject.com.