[Django] #28407: add db column comments to models Field comment_note

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #28407: add db column comments to models Field comment_note

Django
#28407: add  db column comments to models Field comment_note
-------------------------------------+-------------------------------------
               Reporter:  007gzs     |          Owner:  nobody
                   Type:  New        |         Status:  new
  feature                            |
              Component:  Database   |        Version:  1.11
  layer (models, ORM)                |
               Severity:  Normal     |       Keywords:  db comment
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 when use inspectdb make model from db.
 the db column is created by dba, not developer .
 so db column comments set to models Field is helpful for developer.
 like
 {{{
 field = models.IntegerField(blank=True, null=True) #comments in db
 }}}
 [https://github.com/django/django/pull/8738]

--
Ticket URL: <https://code.djangoproject.com/ticket/28407>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/049.64a82000ccaefcbace08f5a79a0f92d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28407: add db column comments to models Field comment_note

Django
#28407: add  db column comments to models Field comment_note
-------------------------------------+-------------------------------------
     Reporter:  007gzs               |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  1.11
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  db comment           |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Description changed by 007gzs:

Old description:

> when use inspectdb make model from db.
> the db column is created by dba, not developer .
> so db column comments set to models Field is helpful for developer.
> like
> {{{
> field = models.IntegerField(blank=True, null=True) #comments in db
> }}}
> [https://github.com/django/django/pull/8738]

New description:

 when use inspectdb make model from db.
 the db column is created by dba, not developer .
 so db column comments set to models Field is helpful for developer.
 like
 {{{
 field = models.IntegerField(blank=True, null=True) #comments in db
 }}}
 [https://github.com/django/django/pull/8770]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.6234b5868e4495bf23148d7931195c24%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28407: Allow inspectdb to introspect db column comments (was: add db column comments to models Field comment_note)

Django
In reply to this post by Django
#28407: Allow inspectdb to introspect db column comments
-------------------------------------+-------------------------------------
     Reporter:  007gzs               |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  1.11
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  db comment           |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted
 * needs_tests:  0 => 1


Comment:

 I think the comment should be prefixed with something like `Column
 comment: `. Also tests are required.

--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.a51c09616ab4eb1a3467955e337c3677%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28407: Allow inspectdb to introspect db column comments

Django
In reply to this post by Django
#28407: Allow inspectdb to introspect db column comments
-------------------------------------+-------------------------------------
     Reporter:  007gzs               |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  1.11
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  db comment           |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by 007gzs):

 sorry i donot know how can i add a db with comment in tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.ae6aacacd28e4a9322976dd5538ac42d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28407: Allow inspectdb to introspect db column comments

Django
In reply to this post by Django
#28407: Allow inspectdb to introspect db column comments
-------------------------------------+-------------------------------------
     Reporter:  007gzs               |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  1.11
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  db comment           |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

 I think it would involve something like adding a
 `BaseDatabaseSchemaEditor.sql_create_column_comment` attribute with the
 SQL for creating a column comment. Then the test can use that.

--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.3537bcbbe1f66a0a10f83d7401da7adc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28407: Allow inspectdb to introspect db column comments

Django
In reply to this post by Django
#28407: Allow inspectdb to introspect db column comments
-------------------------------------+-------------------------------------
     Reporter:  007gzs               |                    Owner:  nobody
         Type:  New feature          |                   Status:  closed
    Component:  Database layer       |                  Version:  1.11
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:  duplicate
     Keywords:  db comment           |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Adding column comments as a model field option is accepted in #18468.

--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.30327cc07b0f206f75b8a6d690134b33%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.