[Django] #28606: Mark CachedStaticFilesStorage as deprecated in Django 2.1

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #28606: Mark CachedStaticFilesStorage as deprecated in Django 2.1

Django
#28606: Mark CachedStaticFilesStorage as deprecated in Django 2.1
------------------------------------------------+------------------------
               Reporter:  Ed Morley             |          Owner:  nobody
                   Type:  Cleanup/optimization  |         Status:  new
              Component:  contrib.staticfiles   |        Version:  master
               Severity:  Normal                |       Keywords:
           Triage Stage:  Unreviewed            |      Has patch:  0
    Needs documentation:  0                     |    Needs tests:  0
Patch needs improvement:  0                     |  Easy pickings:  0
                  UI/UX:  0                     |
------------------------------------------------+------------------------
 `CachedStaticFilesStorage` has a number of drawbacks, and the docs in fact
 already steer people away from using it:
 https://docs.djangoproject.com/en/1.11/ref/contrib/staticfiles/#django.contrib.staticfiles.storage.CachedStaticFilesStorage

 An additional problem is that `HashedFilesMixin` has had to make several
 compromises in order to support `CachedStaticFilesStorage` which
 unfortunately also impacts users of the recommended
 `ManifestStaticFilesStorage` backend (see #28604). When these compromises
 were added in #24452, it was suggested that `CachedStaticFilesStorage`
 should just be deprecated/removed instead.

 It's now too late to mark it as deprecated for Django 2.0, but we can do
 so for Django 2.1 which would end up with its removal being in Django 3.0
 all the same anyway.

 I started this mailing list thread about the deprecation:
 https://groups.google.com/forum/#!topic/django-developers/fmfQvuHBStk

--
Ticket URL: <https://code.djangoproject.com/ticket/28606>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/051.94bebf4dc41cb588d0d79cac826b2b69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage (was: Mark CachedStaticFilesStorage as deprecated in Django 2.1)

Django
#28606: Deprecate CachedStaticFilesStorage
--------------------------------------+------------------------------------
     Reporter:  Ed Morley             |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.staticfiles   |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.c7a234a7a6e7396315f8f7e9c74deeb4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  Masataka
         Type:                       |  Arai
  Cleanup/optimization               |                   Status:  assigned
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Masataka Arai):

 * owner:  nobody => Masataka Arai
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.a7081d7e1ef38369cebfae68c89fe100%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
--------------------------------------+------------------------------------
     Reporter:  Ed Morley             |                    Owner:  (none)
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.staticfiles   |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Masataka Arai):

 * owner:  Masataka Arai => (none)
 * status:  assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.22f167109bcf08c88b095303c60bfcdc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  Gurpreet
         Type:                       |  Singh
  Cleanup/optimization               |                   Status:  assigned
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Gurpreet Singh):

 * owner:  nobody => Gurpreet Singh
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.cd09ab0fc67e99b620ede27b4c4835be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
--------------------------------------+------------------------------------
     Reporter:  Ed Morley             |                    Owner:  (none)
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.staticfiles   |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Gurpreet Singh):

 * status:  assigned => new
 * owner:  Gurpreet Singh => (none)


--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.1fc5278810a5738a54e9e6050eef9c0d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
--------------------------------------+------------------------------------
     Reporter:  Ed Morley             |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.staticfiles   |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/10570 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.72235a991306ff2f087dbb7b211b6833%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.eb029fbe85426f0f7de582aa38cf6723%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f892781b957f674806a227a10c58768f66a48c07" f892781b]:
 {{{
 #!CommitTicketReference repository=""
 revision="f892781b957f674806a227a10c58768f66a48c07"
 Fixed #28606 -- Deprecated CachedStaticFilesStorage.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.00965c8aed3000788e3c9e6d081debde%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"6713926ebe22172e50f283185f969275c326416d" 6713926e]:
 {{{
 #!CommitTicketReference repository=""
 revision="6713926ebe22172e50f283185f969275c326416d"
 Refs #28606 -- Corrected deprecation version for CachedStaticFilesStorage.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.1c4677a07597ae461ed09234f18b2d53%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"a9feec5c70f41b74e2af59725aa3c4c6528b934b" a9feec5c]:
 {{{
 #!CommitTicketReference repository=""
 revision="a9feec5c70f41b74e2af59725aa3c4c6528b934b"
 [2.2.x] Refs #28606 -- Corrected deprecation version for
 CachedStaticFilesStorage.

 Backport of 6713926ebe22172e50f283185f969275c326416d from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.f14e124cce8d749bec12a84eec8e8f2e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28606: Deprecate CachedStaticFilesStorage

Django
In reply to this post by Django
#28606: Deprecate CachedStaticFilesStorage
-------------------------------------+-------------------------------------
     Reporter:  Ed Morley            |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"f1894bae3071da4ee577fc40ae61491f3e03d82c" f1894bae]:
 {{{
 #!CommitTicketReference repository=""
 revision="f1894bae3071da4ee577fc40ae61491f3e03d82c"
 Refs #28606 -- Removed CachedStaticFilesStorage per deprecation timeline.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28606#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.ec3b1f1367dc3550203c970676f11514%40djangoproject.com.