[Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
               Reporter:  Maciej     |          Owner:  nobody
  Olko                               |
                   Type:  Bug        |         Status:  new
              Component:  Core       |        Version:  2.0
  (Other)                            |       Keywords:  i18n, template,
               Severity:  Normal     |  defaults
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  1
                  UI/UX:  1          |
-------------------------------------+-------------------------------------
 Bottom parts (footer) of "Congratulations!" page[1] (rocket taking
 off/default urlconf) cut off text if it is too long. It happens for e.g.
 Russian and Lower Serbian languages. Screenshots:
 [[Image(https://screenshots.firefox.com/H4OzOchrVQCvNp5e/localhost)]]
 [[Image(https://screenshots.firefox.com/dG8BTsWHB4s0F2pL/localhost)]]

 For many other languages, the problem is more of just esthetic nature, as
 the padding to the bottom of page is not equal to the footer top ruler (if
 translations aren't one-liners in effect).

 The footer shouldn't have fixed height. I am afraid that some JavaScript
 is neccessary to calculate footer's height if we are about to keep the
 layout.

 [1] django/django/views/templates/default_urlconf.html

--
Ticket URL: <https://code.djangoproject.com/ticket/28885>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/050.6a1f721055a7307ba468937fe750a490%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

 * cc: FlipperPA (added)
 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.efd1640df56a93ab3ae51f3b5ac1de2a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Timothy
                                     |  Allen
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Timothy Allen):

 * owner:  nobody => Timothy Allen
 * status:  new => assigned


Comment:

 We will tweak the design so it works in more languages, and test with
 Google Translate. Thanks for the catch!

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.c495ee0f5599698f964bac8279ea96db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Timothy
                                     |  Allen
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Old description:

> Bottom parts (footer) of "Congratulations!" page[1] (rocket taking
> off/default urlconf) cut off text if it is too long. It happens for e.g.
> Russian and Lower Serbian languages. Screenshots:
> [[Image(https://screenshots.firefox.com/H4OzOchrVQCvNp5e/localhost)]]
> [[Image(https://screenshots.firefox.com/dG8BTsWHB4s0F2pL/localhost)]]
>
> For many other languages, the problem is more of just esthetic nature, as
> the padding to the bottom of page is not equal to the footer top ruler
> (if translations aren't one-liners in effect).
>
> The footer shouldn't have fixed height. I am afraid that some JavaScript
> is neccessary to calculate footer's height if we are about to keep the
> layout.
>
> [1] django/django/views/templates/default_urlconf.html
New description:

 Bottom parts (footer) of "Congratulations!" page[1] (rocket taking
 off/default urlconf) cut off text if it is too long. It happens for e.g.
 Russian and Lower Serbian languages. Screenshots:
 [[Image(https://screenshots.firefox.com/H4OzOchrVQCvNp5e/localhost)]]
 [[Image(https://screenshots.firefox.com/dG8BTsWHB4s0F2pL/localhost)]]

 For many other languages, the problem is more of just esthetic nature, as
 the padding to the bottom of page is not equal to padding to the footer
 top ruler (if translations aren't one-liners in effect).

 The footer shouldn't have fixed height. I am afraid that some JavaScript
 is neccessary to calculate footer's height if we are about to keep the
 layout.

 [1] django/django/views/templates/default_urlconf.html

--

Comment (by Maciej Olko):

 You can also test it with official Django translations, by just changing
 the [https://docs.djangoproject.com/en/1.11/ref/settings/#language-code
 LANGUAGE_CODE setting]. Language codes that have longest translations
 (AFAIK) are "ru" and "dsb".

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.05860e2953a03e08532c1e4352b44f0c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Timothy
                                     |  Allen
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by Himanshu Chauhan):

 I have tweaked the CSS of the web page so that it does not change original
 design and fix the mentioned bug. Can I claim this ticket and submit the
 patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.21f8695bdaccae5ec2eb175da546a6ee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Timothy
                                     |  Allen
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by Timothy Allen):

 Replying to [comment:4 Himanshu Chauhan]:
 > I have tweaked the CSS of the web page so that it does not change
 original design and fix the mentioned bug. Can I claim this ticket and
 submit the patch?

 Absolutely! My colleague and I were working on a fix, but if you've got
 something complete, by all means take the ticket and issue a P.R. Thanks
 so much!

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.ac8acfd618149d88ae2bb5608578e442%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  (none)
         Type:  Bug                  |                   Status:  new
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Timothy Allen):

 * owner:  Timothy Allen => (none)
 * status:  assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.5803c7a10c9ce4e7f152434f1b668c55%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Himanshu
                                     |  Chauhan
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Himanshu Chauhan):

 * owner:  (none) => Himanshu Chauhan
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.1310d71054897d9a24c7270e39aeac9c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Himanshu
                                     |  Chauhan
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Accepted
  defaults                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Himanshu Chauhan):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/9570 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.0725149298f0c95190b6123e8ab6519d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Himanshu
                                     |  Chauhan
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:
     Keywords:  i18n, template,      |             Triage Stage:  Ready for
  defaults                           |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


Comment:

 The patch looks good. (Screenshots on PR)

 The commit message does not quite match the guidelines, but could be
 adjusted when merging.

 Need to confirm Himanshu submitted the CLA.

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.0135d8b06eabc1608dfdc0195e39e7a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Himanshu
                                     |  Chauhan
         Type:  Bug                  |                   Status:  closed
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  i18n, template,      |             Triage Stage:  Ready for
  defaults                           |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1b753b2d60230974e7d537ddacbcc1ad23348e7c" 1b753b2]:
 {{{
 #!CommitTicketReference repository=""
 revision="1b753b2d60230974e7d537ddacbcc1ad23348e7c"
 Fixed #28885 -- Fixed hidden content at the bottom of the "The install
 worked successfully!" page for some languages.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.443ede03811f2dc22adca762000cf78b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

Django
In reply to this post by Django
#28885: Bottom parts of "Congratulations!" page cut off internationalized content
-------------------------------------+-------------------------------------
     Reporter:  Maciej Olko          |                    Owner:  Himanshu
                                     |  Chauhan
         Type:  Bug                  |                   Status:  closed
    Component:  Core (Other)         |                  Version:  2.0
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  i18n, template,      |             Triage Stage:  Ready for
  defaults                           |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"cc1bdce6740251d33d20dfdf27e2340e4cee0f56" cc1bdce6]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc1bdce6740251d33d20dfdf27e2340e4cee0f56"
 [2.0.x] Fixed #28885 -- Fixed hidden content at the bottom of the "The
 install worked successfully!" page for some languages.

 Backport of 1b753b2d60230974e7d537ddacbcc1ad23348e7c from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28885#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.6d1ff12ac006537b4e32fde6c5e7b71b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.