[Django] #28959: Canceling removing inline Foreign Key does not work

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #28959: Canceling removing inline Foreign Key does not work

Django
#28959: Canceling removing inline Foreign Key does not work
-----------------------------------------+------------------------
               Reporter:  Josh Schneier  |          Owner:  nobody
                   Type:  Bug            |         Status:  new
              Component:  contrib.admin  |        Version:  master
               Severity:  Normal         |       Keywords:
           Triage Stage:  Unreviewed     |      Has patch:  0
    Needs documentation:  0              |    Needs tests:  0
Patch needs improvement:  0              |  Easy pickings:  0
                  UI/UX:  0              |
-----------------------------------------+------------------------
 If you have a Foreign Key to a model that is nullable and has
 `models.SET_NULL` as its `on_delete` handler a small red x appears inline.
 Clicking on that brings up a popover warning. If you then click "No, take
 me back" to cancel the action nothing happens because it's a popover and
 the handler in `cancel.js` is doing `window.history.back()` which doesn't
 work for a separate window.

 This exists going back to at least 1.9

--
Ticket URL: <https://code.djangoproject.com/ticket/28959>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.a46be6b6e066d67feda25be7ed233cd4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing (was: Canceling removing inline Foreign Key does not work)

Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------+------------------------------------
     Reporter:  Josh Schneier  |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.8c517c5af2d08e70ee9690910c7c586f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing

Django
In reply to this post by Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------+------------------------------------
     Reporter:  Josh Schneier  |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by Josh Schneier):

 I'm happy to fix this but the popover code looked a bit complex. Since
 it's isolated to cancel.js would checking for the `is_popover` hidden
 field value (or in the URL) in the handler and then calling
 `window.close()` if it's found be sufficient?

--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.4dd1a41e9e54a955e519c7f8232edfbf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing

Django
In reply to this post by Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------+------------------------------------
     Reporter:  Josh Schneier  |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Josh Schneier):

 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.70d88fa89eb4e91b45bd7204f423bd2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing

Django
In reply to this post by Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------+------------------------------------
     Reporter:  Josh Schneier  |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  1              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Tim Graham):

 * needs_tests:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.b0ec833734bc2c68fe1433dab630f0f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing

Django
In reply to this post by Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------+------------------------------------
     Reporter:  Josh Schneier  |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Josh Schneier):

 * needs_tests:  1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.78757b832561866132b4ec104caaaf89%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing

Django
In reply to this post by Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------------+-------------------------------------
     Reporter:  Josh Schneier        |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.admin        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.ce1be4926de0f5684b29bd53e5be8219%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #28959: Clicking "No, take me back" on the delete selected inline foreign key / one-to-one field confirmation page does nothing

Django
In reply to this post by Django
#28959: Clicking "No, take me back" on the delete selected inline foreign key /
one-to-one field confirmation page does nothing
-------------------------------------+-------------------------------------
     Reporter:  Josh Schneier        |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.admin        |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b60e5fdbb778088b4b7e9e1522808f0c999e1dd9" b60e5fdb]:
 {{{
 #!CommitTicketReference repository=""
 revision="b60e5fdbb778088b4b7e9e1522808f0c999e1dd9"
 Fixed #28959 -- Fixed 'No, take me back' button on admin's inline popup.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28959#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.91269947860b310e1d465f7eba33b16c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.