[Django] #29379: Add autocomplete attribute to contrib.auth fields

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
#29379: Add autocomplete attribute to contrib.auth fields
----------------------------------------+------------------------
               Reporter:  CHI Cheng     |          Owner:  nobody
                   Type:  New feature   |         Status:  new
              Component:  contrib.auth  |        Version:  master
               Severity:  Normal        |       Keywords:
           Triage Stage:  Unreviewed    |      Has patch:  1
    Needs documentation:  0             |    Needs tests:  0
Patch needs improvement:  0             |  Easy pickings:  0
                  UI/UX:  0             |
----------------------------------------+------------------------
 Add autocomplete=username/email/current-password/new-password to
 contrib.auth builtin forms.

 The most useful one is autocomplete=new-password, which prevents browsers
 prefill with current password, Chrome will also suggest a random strong
 password for users who turned on account sync.

 Related docs:
 https://html.spec.whatwg.org/multipage/form-control-
 infrastructure.html#autofill
 https://www.chromium.org/developers/design-documents/form-styles-that-
 chromium-understands
 https://developer.mozilla.org/en-
 US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

--
Ticket URL: <https://code.djangoproject.com/ticket/29379>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.de12ffbb2bef4183a0f70b916b3dd036%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
#29379: Add autocomplete attribute to contrib.auth fields
------------------------------+--------------------------------------
     Reporter:  CHI Cheng     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Unreviewed
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  0
Easy pickings:  0             |                    UI/UX:  0
------------------------------+--------------------------------------
Description changed by CHI Cheng:

Old description:

> Add autocomplete=username/email/current-password/new-password to
> contrib.auth builtin forms.
>
> The most useful one is autocomplete=new-password, which prevents browsers
> prefill with current password, Chrome will also suggest a random strong
> password for users who turned on account sync.
>
> Related docs:
> https://html.spec.whatwg.org/multipage/form-control-
> infrastructure.html#autofill
> https://www.chromium.org/developers/design-documents/form-styles-that-
> chromium-understands
> https://developer.mozilla.org/en-
> US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields
New description:

 Add autocomplete=username/email/current-password/new-password to
 contrib.auth builtin forms.

 Pull request: https://github.com/django/django/pull/9921

 The most useful one is autocomplete=new-password, which prevents browsers
 prefill with current password, Chrome will also suggest a random strong
 password for users who turned on account sync.

 Related docs:
 https://html.spec.whatwg.org/multipage/form-control-
 infrastructure.html#autofill
 https://www.chromium.org/developers/design-documents/form-styles-that-
 chromium-understands
 https://developer.mozilla.org/en-
 US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

--

--
Ticket URL: <https://code.djangoproject.com/ticket/29379#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.3b7de9d1a68492042fcc58a2a56bb7f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
In reply to this post by Django
#29379: Add autocomplete attribute to contrib.auth fields
------------------------------+--------------------------------------
     Reporter:  CHI Cheng     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Unreviewed
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  1
Easy pickings:  0             |                    UI/UX:  0
------------------------------+--------------------------------------
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 This seems OK/good in theory. We're a bit ahead of the curve in terms of
 current browser support so there's a question about when (and whether)
 this gets adopted.

 [https://github.com/django/django/pull/9921 PR] has failures that need
 addressing.

--
Ticket URL: <https://code.djangoproject.com/ticket/29379#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.6e89d980f2fb4472260654193fe624c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
In reply to this post by Django
#29379: Add autocomplete attribute to contrib.auth fields
------------------------------+------------------------------------
     Reporter:  CHI Cheng     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  1
Easy pickings:  0             |                    UI/UX:  0
------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29379#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.2787a32531f43be55d01134f31e96831%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
In reply to this post by Django
#29379: Add autocomplete attribute to contrib.auth fields
------------------------------+------------------------------------
     Reporter:  CHI Cheng     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  1
Easy pickings:  0             |                    UI/UX:  0
------------------------------+------------------------------------
Changes (by Jeff):

 * cc: Jeff (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/29379#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.1afe3cac950431727c0f9b56f22b7d93%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
In reply to this post by Django
#29379: Add autocomplete attribute to contrib.auth fields
------------------------------+------------------------------------
     Reporter:  CHI Cheng     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  1
Easy pickings:  0             |                    UI/UX:  0
------------------------------+------------------------------------

Comment (by sedrubal):

 Hi, what is the status of this pull request? I just wanted to open the
 same pull request and then I found this ticket...

--
Ticket URL: <https://code.djangoproject.com/ticket/29379#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.f21d7dfb8a93c0ae3d92907c0537cbaa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

Django
In reply to this post by Django
#29379: Add autocomplete attribute to contrib.auth fields
------------------------------+------------------------------------
     Reporter:  CHI Cheng     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  1
Easy pickings:  0             |                    UI/UX:  0
------------------------------+------------------------------------

Comment (by Claude Paroz):

 After months of inactivity, feel free to take over the patch (crediting
 the original author), and polish it so as it can get in the review queue
 again.

--
Ticket URL: <https://code.djangoproject.com/ticket/29379#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7460195abf66864876f632cbf4cf3585%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.