[Django] #29452: makemessages command doesn't set .pot file charset properly

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #29452: makemessages command doesn't set .pot file charset properly

Django
#29452: makemessages command doesn't set .pot file charset properly
------------------------------------------------+------------------------
               Reporter:  Bartosz Grabski       |          Owner:  nobody
                   Type:  Uncategorized         |         Status:  new
              Component:  Internationalization  |        Version:  1.11
               Severity:  Normal                |       Keywords:
           Triage Stage:  Unreviewed            |      Has patch:  0
    Needs documentation:  0                     |    Needs tests:  0
Patch needs improvement:  0                     |  Easy pickings:  0
                  UI/UX:  0                     |
------------------------------------------------+------------------------
 When running `python manage.py makemessages`, I'm getting the following
 error:

 {{{
 CommandError: errors happened while running msguniq
 C:\dev\xxx\locale\django.pot:2738: C:\dev\xxx\locale\django.pot: input is
 not valid in "ASCII" encoding
 }}}

 This is because some of my translatable strings contain non-ASCII
 characters. I've checked the code in `makemessages.py` and found the
 culprit:

 {{{
         for line in pot_lines:
             if not found and not header_read:
                 found = True
                 line = line.replace('charset=CHARSET', 'charset=UTF-8')
             if not line and not found:
                 header_read = True
             lines.append(line)
 }}}

 Since `found` is set to `True` on the first iteration, charset is never
 updated as it's usually on line 17.

--
Ticket URL: <https://code.djangoproject.com/ticket/29452>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/057.35bf7f34dd47d2f773a8dbe2423b031f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Uncategorized        |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Bartosz Grabski):

 * owner:  nobody => Bartosz Grabski
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.2eff94c14e828db8683ee172d11f0b7b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Markus Holtermann):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.eeeecd58f2ca84b993cfe6e8868bbed4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Bartosz Grabski):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/9997

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.c7c35850be64a0e9336bb5484775ae59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Ingo Klöcker):

 * needs_better_patch:  0 => 1


Comment:

 I would add a test for this.

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.c1577f3ff4850f250b95061509acea9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Bartosz Grabski):

 Will do.

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.238a00c35c320ebca93dfc69099ec7d0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Ramiro Morales):

 I'm the one who introduced this bug in
 6ab0d1358fc78077064aab88a4fb0a47ca116391. ''Mea culpa''.

 I can contribute a test case (also attached):
 {{{
 #!diff
 diff --git a/tests/i18n/commands/templates/test.html
 b/tests/i18n/commands/templates/test.html
 index cac034e..3868dc1 100644
 --- a/tests/i18n/commands/templates/test.html
 +++ b/tests/i18n/commands/templates/test.html
 @@ -105,3 +105,5 @@ Plural for a `trans` and `blocktrans` collision case
  {% endblocktrans %}

  {% trans "Non-breaking space :" %}
 +
 +{% trans "Nón-ÁSCÍÏ text" %}
 diff --git a/tests/i18n/test_extraction.py b/tests/i18n/test_extraction.py
 index d9ce3b4..e7557fc 100644
 --- a/tests/i18n/test_extraction.py
 +++ b/tests/i18n/test_extraction.py
 @@ -394,6 +394,14 @@ class BasicExtractorTests(ExtractorTests):
              po_contents = fp.read()
              self.assertMsgStr("Größe", po_contents)

 +    def test_pot_charset_header_is_utf8(self):
 +        self.assertFalse(os.path.exists(self.POT_FILE))
 +        management.call_command('makemessages', locale=[LOCALE],
 verbosity=0, keep_pot=True)
 +        self.assertTrue(os.path.exists(self.POT_FILE))
 +        with open(self.POT_FILE, 'r', encoding='utf-8') as fp:
 +            contents = fp.read()
 +            self.assertIn(r'; charset=UTF-8\n"', contents)
 +

  class JavascriptExtractorTests(ExtractorTests):

 }}}

 Problem is I can't reproduce the error condition.

 In the added test case:
 * There is a translatable literal with non-ASCII characters (in a template
 file)
 * The intermediate POT file is created (and preserved for examination)
 * When the POT file is created, the header `"Content-Type: text/plain;
 charset=?????\n"` is verified and it already has the `UFT-8` value for the
 charset.

 Am I missing something? How it comes the created POT file has a `"Content-
 Type: text/plain; charset=CHARSET\n"` header?
 * Is the fact tha OP is running on Windows?
 * Does this happen when extracting literal from .py files? Javascript?

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.ddd3336018e61aa55f8c7d5e10848b18%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Ramiro Morales):

 * Attachment "29452-test.diff" added.

 Test case

--
Ticket URL: <https://code.djangoproject.com/ticket/29452>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.43320bd7b7a93f973da4887a3ef4cbec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Ramiro Morales):

 * Attachment "29452-test.diff" added.

 Test case

--
Ticket URL: <https://code.djangoproject.com/ticket/29452>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.8763fe246206665d5c8a6336b8153864%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

 I think you could just unit test the write_pot_file method with some
 content like:
 {{{
 # SOME DESCRIPTIVE TITLE.
 # Copyright (C) YEAR THE PACKAGE\'S COPYRIGHT HOLDER
 # This file is distributed under the same license as the PACKAGE package.
 # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
 #
 #, fuzzy
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2018-06-07 17:21+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[hidden email]>\n"
 "Language: \n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=CHARSET\n"
 "Content-Transfer-Encoding: 8bit\n"

 #: django/contrib/gis/apps.py:8
 msgid "GIS"
 msgstr ""

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.2cf20bac3be06d6fcb6bc92b9d2e4bf5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Bartosz Grabski):

 Thanks Claude, that was actually my idea. Will do.
 Ramiro: thanks for the tip.

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.69247f51fd6c6994ac45f86adfdb2ae9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Bartosz Grabski):

 Updated PR with test: https://github.com/django/django/pull/9997

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.7badd4cd447e8937eb06f53ee42d5798%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  closed
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2bc014750adb093131f77e4c20bc17ba64b75cac" 2bc01475]:
 {{{
 #!CommitTicketReference repository=""
 revision="2bc014750adb093131f77e4c20bc17ba64b75cac"
 Fixed #29452 -- Fixed makemessages setting charset of .pot files.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.baab818725265f7befa99d934665eb2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  closed
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

 As this was a regression (read comment:6), I'd be willing to backport this
 to the 2.1 branch. Any opposition?

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.fae7189f2ce583360dd875a8a5e481b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29452: makemessages command doesn't set .pot file charset properly

Django
In reply to this post by Django
#29452: makemessages command doesn't set .pot file charset properly
-------------------------------------+-------------------------------------
     Reporter:  Bartosz Grabski      |                    Owner:  Bartosz
                                     |  Grabski
         Type:  Bug                  |                   Status:  closed
    Component:                       |                  Version:  1.11
  Internationalization               |
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"c7d59825d738650e87173d4f9c8781b2e8b8c0c5" c7d59825]:
 {{{
 #!CommitTicketReference repository=""
 revision="c7d59825d738650e87173d4f9c8781b2e8b8c0c5"
 [2.1.x] Fixed #29452 -- Fixed makemessages setting charset of .pot files.

 Backport of 2bc014750adb093131f77e4c20bc17ba64b75cac from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29452#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/072.b4df044b1befb593a24150e3e39b3fc2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.