[Django] #29464: collectstatic verbosity

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #29464: collectstatic verbosity

Django
#29464: collectstatic verbosity
-------------------------------------+-------------------------------------
               Reporter:  David      |          Owner:  nobody
  Szotten                            |
                   Type:             |         Status:  new
  Uncategorized                      |
              Component:  Core       |        Version:  2.0
  (Management commands)              |
               Severity:  Normal     |       Keywords:
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 {{{collectstatic}}} logs {{{"Post-processed foo as bar}}} with level 1,
 but this is a lot of output and may be more suitable to
 level 2, like {{{"Copying foo"}}}



 https://github.com/django/django/blob/e1ebd22558342bb0088a3da3571863a20413fa2a/django/contrib/staticfiles/management/commands/collectstatic.py#L136

--
Ticket URL: <https://code.djangoproject.com/ticket/29464>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/055.eaeb1670bf4257b5bc9ebd1f6210bd05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2 (was: collectstatic verbosity)

Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization
 * version:  2.0 => 2.1
 * component:  Core (Management commands) => contrib.staticfiles


Comment:

 (Follow up to #28973.)

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.ddcfd3a933cb2fb54a168bab7eddad07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * easy:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.a39f4b9b7c4a77a9256236ee09067f9d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
--------------------------------------+------------------------------------
     Reporter:  David Szotten         |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.staticfiles   |                  Version:  2.1
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.ef8e9c1137bf7257b45b290bc69026c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  arthurspa
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by arthurspa):

 * owner:  nobody => arthurspa
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.6b2034ed739e482f4a940ac2c073163c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  assigned
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Arthur Silva):

 Hi @Tim Graham,

 How can I test post_process inside TestCollectionVerbosity class located
 in django/tests/staticfiles_tests/test_management.py ?

 I've tried:


 {{{
     def test_verbosity_1(self):
         stdout = StringIO()
         self.run_collectstatic(verbosity=1, stdout=stdout,
 post_process=True)
         output = stdout.getvalue()
         self.assertIn(self.staticfiles_copied_msg, output)
         self.assertNotIn(self.copying_msg, output)
         self.assertNotIn(self.post_process_msg, output)
 }}}

 where self.post_process_msg is equal to 'Post-process'.

 However I can't make post_process be triggered. So, the test passes even
 message post_process_msg is printed with verbose=1.

 I may be missing some 'storage' initialization.

 Can you give a hint, please?

 Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.1448ba72f1e9a00bf51fe6a35a92f979%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  assigned
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by David Szotten):

 you probably need to enable a storage backend that uses post processing,
 e.g. using


 {{{
 @override_settings(STATICFILES_STORAGE='django.contrib.staticfiles.storage.CachedStaticFilesStorage')
     def test_foo(self):

 }}}

 see
 https://github.com/django/django/blob/7a266e25be1b641111ab5889f9808ff6d258d27f/django/contrib/staticfiles/management/commands/collectstatic.py#L125

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.eb6fb423bd86ed4f5fc40e07f64bc4a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  closed
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Arthur Silva):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Thanks David.

 I've submitted a [https://github.com/django/django/pull/10042 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.c25b9a105037f6398a4eca7284ef7815%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  new
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * status:  closed => new
 * has_patch:  0 => 1
 * resolution:  fixed =>


Comment:

 The ticket is closed when the PR is merged. You should instead check "Has
 patch" when adding a pull request.

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.55a39975a1b342b928467c9d4b7dd622%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  new
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Arthur Silva):

 My bad.

 Thanks for changing it to "Has patch".

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.fa96d1eef729b8f095918c792cdabe5f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  closed
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bc1435551c0cfaf4a22aff8216990b909005dba9" bc143555]:
 {{{
 #!CommitTicketReference repository=""
 revision="bc1435551c0cfaf4a22aff8216990b909005dba9"
 Fixed #29464 -- Silenced post-process messages in collectstatic's default
 verbosity.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.49101668bf0074475166b7ec66482cd6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29464: Move collectstatic post processing messages to verbosity 2

Django
In reply to this post by Django
#29464: Move collectstatic post processing messages to verbosity 2
-------------------------------------+-------------------------------------
     Reporter:  David Szotten        |                    Owner:  Arthur
         Type:                       |  Silva
  Cleanup/optimization               |                   Status:  closed
    Component:  contrib.staticfiles  |                  Version:  2.1
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"91a02dce97ec677933527deddcce230e6e7ba7c9" 91a02dce]:
 {{{
 #!CommitTicketReference repository=""
 revision="91a02dce97ec677933527deddcce230e6e7ba7c9"
 [2.1.x] Fixed #29464 -- Silenced post-process messages in collectstatic's
 default verbosity.

 Backport of bc1435551c0cfaf4a22aff8216990b909005dba9 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29464#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.01947d4ace8141cec49775d15f599ed4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.