[Django] #29548: Add official support for MariaDB

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #29548: Add official support for MariaDB

Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
               Reporter:  Tim        |          Owner:  nobody
  Graham                             |
                   Type:  New        |         Status:  new
  feature                            |
              Component:  Database   |        Version:  master
  layer (models, ORM)                |
               Severity:  Normal     |       Keywords:
           Triage Stage:  Accepted   |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 The MySQL backend mostly works with MariaDB but there are a few test
 failures, mainly regarding feature detection based on version number.

 [https://groups.google.com/d/topic/django-
 developers/31j1dNOZ7zc/discussion django-developers discussion] and
 [https://github.com/django/django/pull/10135 WIP PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/29548>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.fa495ac22d299ca318bd0f394b781676%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

 This [https://github.com/django/django/pull/10141 PR] addresses the GIS
 part.

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.dba5025b38673d179ef7215c242ef3f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * cc: felixxm (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.de588832747713162ccd12449d7b28c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tom Forbes):

 * cc: Tom Forbes (added)


Comment:

 I've fixed all the failing non-gis tests here:
 https://github.com/django/django/pull/10135

 I've been thinking about how to best support version checking both MySQL
 and MariaDB. You always have to check the MariaDB and MySQL versions
 carefully as they are numerically comparable but not logically.
 `connection.mysql_version > (8, 0, 0)` is True for all MariaDB versions,
 even if the feature you're testing is not compatible. We could add a
 `mariadb_version` property that returns an object that always compares to
 False if the database is not Mariadb, and vice versa for `mysql_version`?

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7ca9ea31115fcd2ed62b1b3864cc2fb8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"45c035c823bfbd642dc1490f1c555316af403c4c" 45c035c8]:
 {{{
 #!CommitTicketReference repository=""
 revision="45c035c823bfbd642dc1490f1c555316af403c4c"
 Refs #29548 -- Fixed non-GIS test failures on MariaDB.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.27e650c149f255ffbe645a0023eb73b8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

 I installed MariaDB 10.3 and found the attached test failures for window
 expressions.

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.c9a8525e58aa5905a2237bbf2efb815d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * Attachment "window-expression-failures.txt" added.


--
Ticket URL: <https://code.djangoproject.com/ticket/29548>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.378120ec59944ac3f566cdabfd3503f1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

 In [changeset:"c28bf990d71a8befb954482e3d6a925e89f3176f" c28bf990]:
 {{{
 #!CommitTicketReference repository=""
 revision="c28bf990d71a8befb954482e3d6a925e89f3176f"
 Refs #29548 -- Fixed GIS tests on MariaDB
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7e3d74c6b0a8c938522e6f91b0136a6c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tom Forbes):

 PR for window function failures:
 https://github.com/django/django/pull/10228

 I've not had much experience with window expressions, but after doing some
 exploration it seems MariaDB has a few annoying quirks. Firstly the
 results of a query that uses window functions are not implicitly ordered,
 so the ordering has to be repeated. All examples in the MariaDB KB show
 this: https://mariadb.com/kb/en/library/window-functions-overview/. For
 these tests I just added a conditional `.order()` call if it's MariaDB.

 Secondly 'RANGE' frames have a limitation that's not present in other
 databases (https://jira.mariadb.org/browse/MDEV-11747). For this I just
 adapted the test to work around this limitation.

 And lastly `LEAD` and `LAG` have no `default` parameter
 (https://jira.mariadb.org/browse/MDEV-12981). I just skipped these tests.

 The PR needs more work done before it's ready, but if I don't have time I
 thought I would share what I've got so far for anyone else to pick up.
 Tests pass locally with MariaDB 10.3.

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.87c90f572e80b1d31b0399d015d354d9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29548: Add official support for MariaDB

Django
In reply to this post by Django
#29548: Add official support for MariaDB
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"4198445afcba94eb7a25b50c96ec6c2694ed2192" 4198445]:
 {{{
 #!CommitTicketReference repository=""
 revision="4198445afcba94eb7a25b50c96ec6c2694ed2192"
 Refs #29548 -- Fixed failing window tests on MariaDB 10.3.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29548#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.eb4d5859396c5d814996fc5a362de7f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.