[Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
--------------------------------------------+------------------------
               Reporter:  Simon Charette    |          Owner:  (none)
                   Type:  Bug               |         Status:  new
              Component:  contrib.postgres  |        Version:  master
               Severity:  Normal            |       Keywords:
           Triage Stage:  Unreviewed        |      Has patch:  0
    Needs documentation:  0                 |    Needs tests:  0
Patch needs improvement:  0                 |  Easy pickings:  1
                  UI/UX:  0                 |
--------------------------------------------+------------------------
 As discovered in https://code.djangoproject.com/ticket/25591#comment:6
 `FloatRangeField` uses `numrange` as database type which is not
 appropriate to store doubles/floats which is what `FloatField` uses.

 `DecimalField` on the other hand uses `numeric` as datatype which makes a
 better abstraction resolution. I suggest we keep `class
 FloatRangeField(DecimalRangeField)` field around with warning on
 `__init__` during the deprecation period.

--
Ticket URL: <https://code.djangoproject.com/ticket/29598>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.b9e3789a51d82c22f277960a05e62628%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
----------------------------------+------------------------------------
     Reporter:  Simon Charette    |                    Owner:  (none)
         Type:  Bug               |                   Status:  new
    Component:  contrib.postgres  |                  Version:  master
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  1                 |                    UI/UX:  0
----------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.ff16af94fce8bf3e6a2fce92e701895a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
----------------------------------+------------------------------------
     Reporter:  Simon Charette    |                    Owner:  Rowan
         Type:  Bug               |                   Status:  assigned
    Component:  contrib.postgres  |                  Version:  master
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  1                 |                    UI/UX:  0
----------------------------------+------------------------------------
Changes (by Rowan):

 * owner:  (none) => Rowan
 * status:  new => assigned


Comment:

 I'd like to help out with this ticket. Should the docs reference the fact
 that the field used to be called `FloatRangeField`, as well?

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.9b69109303dd7ed097b1170288a0bfdf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
----------------------------------+------------------------------------
     Reporter:  Simon Charette    |                    Owner:  Rowan
         Type:  Bug               |                   Status:  assigned
    Component:  contrib.postgres  |                  Version:  master
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  1                 |                    UI/UX:  0
----------------------------------+------------------------------------

Comment (by Simon Charette):

 Rowan, I think a note mentioning it would be useful.

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.a2d8f492826417f7d0f1b5d856d2a455%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
----------------------------------+------------------------------------
     Reporter:  Simon Charette    |                    Owner:  Rowan
         Type:  Bug               |                   Status:  assigned
    Component:  contrib.postgres  |                  Version:  master
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  1                 |                    UI/UX:  0
----------------------------------+------------------------------------

Comment (by Tim Graham):

 See [https://docs.djangoproject.com/en/dev/internals/contributing/writing-
 code/submitting-patches/#deprecating-a-feature Deprecating a feature] for
 a checklist of tasks.

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.9fc8df08c0912a37556aa60735445651%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Stefano Chiodino):

 * owner:  Rowan => Stefano Chiodino


--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.fd7dd2277e1ace6da7170354355ac14e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Stefano Chiodino):

 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.64feb730ec720b0dbb1cb7485ed20832%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Stefano Chiodino):

 https://github.com/django/django/pull/10415

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.4b6a9aab9b992c7a8ae2ead5b3ecc5ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7b004b4d78e4785a647662b24af9b3c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Vishvajit Pathak):

 * cc: Vishvajit Pathak (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.39593a222ef479ea95b681b8e743fc69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


Comment:

 I updated the pull request. Simon, could you review?

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.f8fd5de62012d00ec3dad4587fa20d97%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

 * stage:  Accepted => Ready for checkin


Comment:

 I couldn't identify any blocker. LGTM.

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.c91f6924cb3928ae7ff2cbd37a9dcc8c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6de7f9ec60fbdc59797bc21803f16260bd203f04" 6de7f9e]:
 {{{
 #!CommitTicketReference repository=""
 revision="6de7f9ec60fbdc59797bc21803f16260bd203f04"
 Fixed #29598 -- Deprecated FloatRangeField in favor of DecimalRangeField.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.77c7bfcd0ab116be75310c9a4bbd2ac2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField

Django
In reply to this post by Django
#29598: contrib.postgres.FloatRangeField should be renamed DecimalRangeField
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Stefano
                                     |  Chiodino
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"b47bb4c4a74f926111bdad4a6daae14ceed6f2dd" b47bb4c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="b47bb4c4a74f926111bdad4a6daae14ceed6f2dd"
 Refs #29598 -- Removed FloatRangeField per deprecation timeline.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29598#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.d36a4d1c430716bbd7ba9e1a50f9ff2b%40djangoproject.com.