[Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
               Reporter:  Moritz     |          Owner:  nobody
  Pfeiffer                           |
                   Type:  Bug        |         Status:  new
              Component:             |        Version:  2.2
  contrib.admin                      |       Keywords:
               Severity:  Normal     |  RelatedFieldListFilter,
                                     |  RelatedOnlyFieldListFilter,
           Triage Stage:             |  ordering
  Unreviewed                         |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  1          |
-------------------------------------+-------------------------------------
 RelatedFieldListFilter doesn't fall back to the ordering defined in
 Model._meta.ordering.

 Ordering gets set to an empty tuple in
 https://github.com/django/django/blob/2.2.1/django/contrib/admin/filters.py#L196
 and unless ordering is defined on the related model's ModelAdmin class it
 stays an empty tuple.  IMHO it should fall back to the ordering defined in
 the related model's Meta.ordering field.

 RelatedOnlyFieldListFilter doesn't order the related model at all, even if
 ordering is defined on the related model's ModelAdmin class.
 That's because the call to field.get_choices
 https://github.com/django/django/blob/2.2.1/django/contrib/admin/filters.py#L422
 omits the ordering kwarg entirely.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/058.9b3f1707cdd39957d4f98564ab8dad55%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
  RelatedFieldListFilter,            |  Unreviewed
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Moritz Pfeiffer):

 * Attachment "django_filter_ordering.zip" added.

 Sample project illustrating the problem. Navigate to /admin/foo/book and
 observer the order of Author in the list filters.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.bdc299fa443e819f44f134ab13ba202b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
  RelatedFieldListFilter,            |  Unreviewed
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Moritz Pfeiffer):

 * Attachment "Screenshot 2019-05-06 at 15.49.17.jpg" added.

 Screenshot of RelatedOnlyFieldListFilter not ordering items.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.56f7c05e50a7487d95e5b40837cc3323%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, yes, seems a reasonable suggestion if you'd like to work on it.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.12bbd5e6ee6a9730f61384ccd7123277%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by zeynel):

 * status:  new => assigned
 * owner:  nobody => zeynel


--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.1177c23fed3d3421f4b5e26d2473d655%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by zeynel):

 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.f0d4b4924966eae5d682391538ba9789%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * needs_better_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.bb4b9aa20ba91c4c5bae3d01575f29d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Althalus):

 * needs_better_patch:  1 => 0


Comment:

 Hello. We've updated our django recently and faced this bug. For me it
 seems like a quite big regression.
 As I see in PR, patch was updated and appropriate tests were added too so
 I suggest to consider including it in 2.2.4 and backporting to (at least)
 2.1.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.987d280b18e80ff84582d25cb40d036b%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * version:  2.2 => master


Comment:

 As far as I'm concerned it's not a regression and doesn't qualify for a
 backport. It's on my list and should be fixed in Django 3.0.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.ca98b7725db4885f0b823a8d900db865%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * severity:  Normal => Release blocker


Comment:

 I closed #30703 as a duplicate. It is a regression introduced in #29835.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.1bbf53627a9b240f2cc7febd46537868%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by felixxm):

 Alternate [https://github.com/django/django/pull/11661 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.a9718fd1fb1a7787d37d17255de875db%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by tinodb):

 I'd argue it ''is'' a regression. It worked before and is clearly broken
 now.

 Any workarounds for the moment?

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.c1e1ec2e4f1b83bc4aef5f74b3a9caed%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by felixxm):

 Replying to [comment:9 tinodb]:
 > I'd argue it ''is'' a regression. It worked before and is clearly broken
 now.
 >
 > Any workarounds for the moment?

 Yes we marked this as a regression and release blocker (please check my
 previous [https://code.djangoproject.com/ticket/30449#comment:7 comment]).

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.d862ab90138df51c16f03586cebf2f98%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by felixxm):

 `RelatedOnlyFieldListFilter` part is not a regression because it never
 worked.

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.a199ffc5f2902fec8e4768f0ba73e9fe%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"00035672a460b6eb5442d2837bc783f8af28c6f3" 00035672]:
 {{{
 #!CommitTicketReference repository=""
 revision="00035672a460b6eb5442d2837bc783f8af28c6f3"
 Fixed #30449 -- Fixed RelatedFieldListFilter/RelatedOnlyFieldListFilter to
 respect model's Meta.ordering.

 Regression in 6d4e5feb79f7eabe8a0c7c4b87f25b1a7f87ca0b.

 Co-Authored-By: Mariusz Felisiak <[hidden email]>
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.be74aae4822b9002ba29ce49b3179ef4%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"8289fc55fff879df273cb95fdd1b039447f85783" 8289fc55]:
 {{{
 #!CommitTicketReference repository=""
 revision="8289fc55fff879df273cb95fdd1b039447f85783"
 Refs #30449 -- Made RelatedOnlyFieldListFilter respect
 ModelAdmin.ordering.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.6ff6225e08e8623ac6ab55b90cf41826%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30449: Ordering problem in admin.RelatedFieldListFilter and admin.RelatedOnlyFieldListFilter

Django
In reply to this post by Django
#30449: Ordering problem in admin.RelatedFieldListFilter and
admin.RelatedOnlyFieldListFilter
-------------------------------------+-------------------------------------
     Reporter:  Moritz Pfeiffer      |                    Owner:  zeynel
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.admin        |                  Version:  master
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
  RelatedFieldListFilter,            |
  RelatedOnlyFieldListFilter,        |
  ordering                           |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"c2732e6839fffd96b136607f10af95fe58e0de17" c2732e6]:
 {{{
 #!CommitTicketReference repository=""
 revision="c2732e6839fffd96b136607f10af95fe58e0de17"
 [2.2.x] Fixed #30449 -- Fixed
 RelatedFieldListFilter/RelatedOnlyFieldListFilter to respect model's
 Meta.ordering.

 Regression in 6d4e5feb79f7eabe8a0c7c4b87f25b1a7f87ca0b.

 Co-Authored-By: Mariusz Felisiak <[hidden email]>

 Backport of 00035672a460b6eb5442d2837bc783f8af28c6f3 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30449#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/073.ba6a3ebbb229ea659d4c783813eabc76%40djangoproject.com.