[Django] #30750: Add support for check constraints on MySQL 8.0.16+.

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
               Reporter:  felixxm    |          Owner:  nobody
                   Type:  New        |         Status:  new
  feature                            |
              Component:  Database   |        Version:  master
  layer (models, ORM)                |       Keywords:  MySQL, check
               Severity:  Normal     |  constraints
           Triage Stage:  Accepted   |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 MySQL 8.0.16+ supports check constraints (see
 [https://dev.mysql.com/doc/refman/8.0/en/create-table-check-
 constraints.html documentation]), we should support them in Django.

--
Ticket URL: <https://code.djangoproject.com/ticket/30750>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/050.36ca65602f1b57c9d1be56792f0b399e%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * Attachment "30750.diff" added.

 patch

--
Ticket URL: <https://code.djangoproject.com/ticket/30750>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.b343bfe2a779dde6fa097f972ed23dd2%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by felixxm):

 I've started to work on a patch but still a lot of `schema` tests are
 failing on MySQL 8.

--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.38a315477be53f40c5954850bfe9cc89%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Adam (Chainz) Johnson):

 Thanks for making the ticket Mariusz. Yeah MySQL 8 is quite a change.

--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.a9a1469e420d2bf63d942dfdad320624%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Hasan Ramezani):

 @felixxm can I continue your work on this ticket?

--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.a255ba01006f7c0ce7bb14853b2e8887%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by felixxm):

 Hasan, sure feel free.

--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.036fd3a60bd89dfc1e1038645164a1be%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  New feature          |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.7aa30a741dd32cd559cdc39df972cb19%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  New feature          |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

 * has_patch:  0 => 1


Comment:

 @felixxm, I fixed the [https://github.com/django/django/pull/11743/files
 #diff-888b45a0a8f38ee67e8d22403cf994dbL1133 test_alter_db_table_case
 test].

 The problem was that the table belongs to the `Author` model couldn't be
 dropped because when the test rename table to the uppercase name,  the
 `_meta.db_table` has the old name(lowercase name).

 So I added another rename to return the table to the original name.

--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.de927df3e049c9e8cb80842567f8393a%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30750: Add support for check constraints on MySQL 8.0.16+.

Django
In reply to this post by Django
#30750: Add support for check constraints on MySQL 8.0.16+.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  New feature          |                   Status:  closed
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  MySQL, check         |             Triage Stage:  Accepted
  constraints                        |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e2c6a0858d7d9ad85eda353076a5b46608b704a9" e2c6a08]:
 {{{
 #!CommitTicketReference repository=""
 revision="e2c6a0858d7d9ad85eda353076a5b46608b704a9"
 Fixed #30750 -- Added support for check constraints on MySQL 8.0.16+.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.53fadc5d52709fd48de0b67a5f154386%40djangoproject.com.