[Django] #30766: Refactor ExceptionReporter to allow overriding cookies filter.

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #30766: Refactor ExceptionReporter to allow overriding cookies filter.

Django
#30766: Refactor ExceptionReporter to allow overriding cookies filter.
------------------------------------------------+------------------------
               Reporter:  Nasir Hussain         |          Owner:  (none)
                   Type:  Cleanup/optimization  |         Status:  new
              Component:  Error reporting       |        Version:  master
               Severity:  Normal                |       Keywords:
           Triage Stage:  Unreviewed            |      Has patch:  0
    Needs documentation:  0                     |    Needs tests:  0
Patch needs improvement:  0                     |  Easy pickings:  0
                  UI/UX:  0                     |
------------------------------------------------+------------------------
 Since now we are allowing to use custom ExceptionRepoter subclass in
 #29714. We should refactor ExceptionReporter and move
 [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
 cookies] extraction to a function like we are doing for POST
 [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
 here] so that It is easy to override sensitive cookies filtering in the
 custom subclass of ExceptionRepoter.

--
Ticket URL: <https://code.djangoproject.com/ticket/30766>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/054.e71c250db572ae58795271813ce38ecc%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30766: Make it easier to override custom ExceptionReporter subclass functions. (was: Refactor ExceptionReporter to allow overriding cookies filter.)

Django
#30766: Make it easier to override custom ExceptionReporter subclass functions.
-------------------------------------+-------------------------------------
     Reporter:  Nasir Hussain        |                    Owner:  (none)
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Error reporting      |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Nasir Hussain):

 * has_patch:  0 => 1


Old description:

> Since now we are allowing to use custom ExceptionRepoter subclass in
> #29714. We should refactor ExceptionReporter and move
> [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
> cookies] extraction to a function like we are doing for POST
> [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
> here] so that It is easy to override sensitive cookies filtering in the
> custom subclass of ExceptionRepoter.

New description:

 Since now we are allowing to use custom ExceptionRepoter subclass in
 #29714. We should refactor ExceptionReporter and move
 [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
 cookies] extraction to a function like we are doing for POST
 [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
 here] so that It is easy to override sensitive cookies filtering in the
 custom subclass of ExceptionRepoter.
 [https://github.com/django/django/pull/11748 Patch], I could add unit
 tests if required.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/069.b720076ded0e4921bfe777cb2b1a164d%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30766: Make it easier to override ExceptionReporter functions in custom subclass. (was: Make it easier to override custom ExceptionReporter subclass functions.)

Django
In reply to this post by Django
#30766: Make it easier to override ExceptionReporter functions in custom subclass.
-------------------------------------+-------------------------------------
     Reporter:  Nasir Hussain        |                    Owner:  (none)
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Error reporting      |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/069.12970ef7cfdc4576d7db034305ecc79a%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30766: Make it easier to override ExceptionReporter functions in custom subclass.

Django
In reply to this post by Django
#30766: Make it easier to override ExceptionReporter functions in custom subclass.
-------------------------------------+-------------------------------------
     Reporter:  Nasir Hussain        |                    Owner:  (none)
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  Error reporting      |                  Version:  master
     Severity:  Normal               |               Resolution:  invalid
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Nasir Hussain):

 * status:  new => closed
 * resolution:   => invalid


--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/069.5377a085a6419c2e867645f51c85fdac%40djangoproject.com.