[Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
               Reporter:  felixxm    |          Owner:  nobody
                   Type:  Bug        |         Status:  new
              Component:  Database   |        Version:  3.0
  layer (models, ORM)                |
               Severity:  Release    |       Keywords:
  blocker                            |
           Triage Stage:  Accepted   |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 models.E015 is raised when Meta.ordering contains `__pk` of a related
 field, e.g.:

 {{{
 test_app.SomeModel: (models.E015) 'ordering' refers to the nonexistent
 field, related field, or lookup 'option__pk'.
 }}}

 Regression in 440505cb2cadbe1a5b9fba246bcde6c04f51d07e.

--
Ticket URL: <https://code.djangoproject.com/ticket/30798>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/050.00fcd5f2e87bc68fe8c042d21c494393%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * Attachment "test-30798.diff" added.

 Regression test.

--
Ticket URL: <https://code.djangoproject.com/ticket/30798>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.34dc35f372ffa597aacc2cd287403613%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
In reply to this post by Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned


Comment:

 Thanks @felixxm for the test. I will prepare a fix for it.

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.b03bce1d20e2c4601db9f87f4ddcce2b%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
In reply to this post by Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.52691eca2fb1d0bec04db35ad5655c26%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
In reply to this post by Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"c7944628a1979453468d67818c63957532d396d8" c7944628]:
 {{{
 #!CommitTicketReference repository=""
 revision="c7944628a1979453468d67818c63957532d396d8"
 Refs #30798 -- Prevented chaining fields from the same related model
 multiple times in model Meta.ordering.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.6b09c42c855be9b1f9b1a1ebbf93f006%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
In reply to this post by Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"95a11578ce41de1e152fe7d173f109e280aebd6d" 95a11578]:
 {{{
 #!CommitTicketReference repository=""
 revision="95a11578ce41de1e152fe7d173f109e280aebd6d"
 Fixed #30798 -- Fixed Meta.ordering validation for pk of related fields.

 Regression in 440505cb2cadbe1a5b9fba246bcde6c04f51d07e.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.52e122da155a16b65f3bebad8108a188%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
In reply to this post by Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"da8f85aa82a8810cac8c0225c1f8862e5d9aea64" da8f85a]:
 {{{
 #!CommitTicketReference repository=""
 revision="da8f85aa82a8810cac8c0225c1f8862e5d9aea64"
 [3.0.x] Refs #30798 -- Prevented chaining fields from the same related
 model multiple times in model Meta.ordering.

 Backport of c7944628a1979453468d67818c63957532d396d8 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.bd7090526d4ea4d1827e53133bb6e10d%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

Django
In reply to this post by Django
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
     Reporter:  felixxm              |                    Owner:  Hasan
                                     |  Ramezani
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  3.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"0dc39ca8677347ecf25aebd056a130cdbfb8df21" 0dc39ca8]:
 {{{
 #!CommitTicketReference repository=""
 revision="0dc39ca8677347ecf25aebd056a130cdbfb8df21"
 [3.0.x] Fixed #30798 -- Fixed Meta.ordering validation for pk of related
 fields.

 Regression in 440505cb2cadbe1a5b9fba246bcde6c04f51d07e.

 Backport of 95a11578ce41de1e152fe7d173f109e280aebd6d from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.cf38fb53ef3e2892f45231b1eddba16a%40djangoproject.com.