[Django] #30810: WatchmanReloaderTests fail with AttributeError: type object 'WatchmanReloader' has no attribute 'client_timeout'

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #30810: WatchmanReloaderTests fail with AttributeError: type object 'WatchmanReloader' has no attribute 'client_timeout'

Django
#30810: WatchmanReloaderTests fail with AttributeError: type object
'WatchmanReloader' has no attribute 'client_timeout'
-------------------------------------+-------------------------------------
               Reporter:             |          Owner:  nobody
  poligarcia                         |
                   Type:             |         Status:  new
  Uncategorized                      |
              Component:  Utilities  |        Version:  master
               Severity:  Normal     |       Keywords:  utilities,
           Triage Stage:             |  autoreloader, watchman
  Unreviewed                         |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 Running Django's test suite fails with:

 {{{
 ======================================================================
 ERROR: test_setting_timeout_from_environment_variable
 (utils_tests.test_autoreload.WatchmanReloaderTests)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
 line 59, in testPartExecutor
     yield
   File
 "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
 line 628, in run
     testMethod()
   File
 "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/mock.py",
 line 1626, in _inner
     return f(*args, **kw)
   File
 "/Users/poli/work/django/django/tests/utils_tests/test_autoreload.py",
 line 654, in test_setting_timeout_from_environment_variable
     self.assertEqual(self.RELOADER_CLS.client_timeout, 10)
 AttributeError: type object 'WatchmanReloader' has no attribute
 'client_timeout'
 }}}

 My environment:

 * Mac OSX 10.14.16
 * Python 3.7.4
 * watchman 4.9.0

 The `WatchmanReloaderTests` are marked with
 `skip_unless_watchman_available`, so you'll need `watchman` to be able to
 reproduce this.

--
Ticket URL: <https://code.djangoproject.com/ticket/30810>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/053.8eb14feac5e625b6ca98ca6f76b5edd9%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30810: WatchmanReloaderTests error with AttributeError: type object 'WatchmanReloader' has no attribute 'client_timeout' (was: WatchmanReloaderTests fail with AttributeError: type object 'WatchmanReloader' has no attribute 'client_timeout')

Django
#30810: WatchmanReloaderTests error with AttributeError: type object
'WatchmanReloader' has no attribute 'client_timeout'
-------------------------------------+-------------------------------------
     Reporter:  poligarcia           |                    Owner:  nobody
         Type:  Uncategorized        |                   Status:  new
    Component:  Utilities            |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  utilities,           |             Triage Stage:
  autoreloader, watchman             |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Description changed by poligarcia:

Old description:

> Running Django's test suite fails with:
>
> {{{
> ======================================================================
> ERROR: test_setting_timeout_from_environment_variable
> (utils_tests.test_autoreload.WatchmanReloaderTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File
> "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
> line 59, in testPartExecutor
>     yield
>   File
> "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
> line 628, in run
>     testMethod()
>   File
> "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/mock.py",
> line 1626, in _inner
>     return f(*args, **kw)
>   File
> "/Users/poli/work/django/django/tests/utils_tests/test_autoreload.py",
> line 654, in test_setting_timeout_from_environment_variable
>     self.assertEqual(self.RELOADER_CLS.client_timeout, 10)
> AttributeError: type object 'WatchmanReloader' has no attribute
> 'client_timeout'
> }}}
>
> My environment:
>
> * Mac OSX 10.14.16
> * Python 3.7.4
> * watchman 4.9.0
>
> The `WatchmanReloaderTests` are marked with
> `skip_unless_watchman_available`, so you'll need `watchman` to be able to
> reproduce this.
New description:

 Running Django's test suite errors with:

 {{{
 ======================================================================
 ERROR: test_setting_timeout_from_environment_variable
 (utils_tests.test_autoreload.WatchmanReloaderTests)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
 line 59, in testPartExecutor
     yield
   File
 "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
 line 628, in run
     testMethod()
   File
 "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/mock.py",
 line 1626, in _inner
     return f(*args, **kw)
   File
 "/Users/poli/work/django/django/tests/utils_tests/test_autoreload.py",
 line 654, in test_setting_timeout_from_environment_variable
     self.assertEqual(self.RELOADER_CLS.client_timeout, 10)
 AttributeError: type object 'WatchmanReloader' has no attribute
 'client_timeout'
 }}}

 My environment:

 * Mac OSX 10.14.16
 * Python 3.7.4
 * watchman 4.9.0

 The `WatchmanReloaderTests` are marked with
 `skip_unless_watchman_available`, so you'll need `watchman` to be able to
 reproduce this.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30810#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.44d6014bd6d647a763b634926afca83e%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30810: WatchmanReloaderTests error with AttributeError: type object 'WatchmanReloader' has no attribute 'client_timeout'

Django
In reply to this post by Django
#30810: WatchmanReloaderTests error with AttributeError: type object
'WatchmanReloader' has no attribute 'client_timeout'
-------------------------------------+-------------------------------------
     Reporter:  Poli García          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Utilities            |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  utilities,           |             Triage Stage:
  autoreloader, watchman             |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Poli García):

 * type:  Uncategorized => Bug


--
Ticket URL: <https://code.djangoproject.com/ticket/30810#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.42e14770a6fc396e149e1ce7bbefa904%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable() fails with AttributeError. (was: WatchmanReloaderTests error with AttributeError: type object 'WatchmanReloader' has no attribute 'client_timeout')

Django
In reply to this post by Django
#30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable()
fails with AttributeError.
-------------------------------------+-------------------------------------
     Reporter:  Poli García          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Utilities            |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:  utilities,           |             Triage Stage:  Accepted
  autoreloader, watchman             |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * has_patch:  0 => 1
 * version:  master => 2.2
 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/11833 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/30810#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.183f16fc78ced79701ffa3d3a0393bb4%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable() fails with AttributeError.

Django
In reply to this post by Django
#30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable()
fails with AttributeError.
-------------------------------------+-------------------------------------
     Reporter:  Poli García          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Utilities            |                  Version:  2.2
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  utilities,           |             Triage Stage:  Accepted
  autoreloader, watchman             |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2fd610eb301dc01e100befed891e8007fd2e981f" 2fd610eb]:
 {{{
 #!CommitTicketReference repository=""
 revision="2fd610eb301dc01e100befed891e8007fd2e981f"
 Fixed #30810 -- Fixed
 WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.

 client_timeout is an instance attribute.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30810#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.fa78fa321d07fc82d536a9adcbcd92f6%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable() fails with AttributeError.

Django
In reply to this post by Django
#30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable()
fails with AttributeError.
-------------------------------------+-------------------------------------
     Reporter:  Poli García          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Utilities            |                  Version:  2.2
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  utilities,           |             Triage Stage:  Accepted
  autoreloader, watchman             |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"49dcb5d3ba688ea45eb5fea66b6a4c82361e6e54" 49dcb5d3]:
 {{{
 #!CommitTicketReference repository=""
 revision="49dcb5d3ba688ea45eb5fea66b6a4c82361e6e54"
 [3.0.x] Fixed #30810 -- Fixed
 WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.

 client_timeout is an instance attribute.

 Backport of 2fd610eb301dc01e100befed891e8007fd2e981f from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30810#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.f8c9fea0c7b4d0061d6a6a91aed61c44%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable() fails with AttributeError.

Django
In reply to this post by Django
#30810: WatchmanReloaderTests.test_setting_timeout_from_environment_variable()
fails with AttributeError.
-------------------------------------+-------------------------------------
     Reporter:  Poli García          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Utilities            |                  Version:  2.2
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  utilities,           |             Triage Stage:  Accepted
  autoreloader, watchman             |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"38af2579881ed476ecd6bbde5b2329fa22d54210" 38af2579]:
 {{{
 #!CommitTicketReference repository=""
 revision="38af2579881ed476ecd6bbde5b2329fa22d54210"
 [2.2.x] Fixed #30810 -- Fixed
 WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.

 client_timeout is an instance attribute.

 Backport of 2fd610eb301dc01e100befed891e8007fd2e981f from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30810#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.ace2ee264b8528ba29560cd501cd7b03%40djangoproject.com.