[Django] #30964: macOS test failure

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #30964: macOS test failure

Django
#30964: macOS test failure
-------------------------------------+-------------------------------------
               Reporter:  Johannes   |          Owner:  nobody
  Hoppe                              |
                   Type:  Bug        |         Status:  new
              Component:  Database   |        Version:  2.2
  layer (models, ORM)                |
               Severity:  Normal     |       Keywords:
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 This bug was discovered during GitHub action trails, while running the
 test suite agianst macOS, see also:
 https://github.com/codingjoe/django/runs/292481675

 {{{

 FAIL: test_db_table (schema.tests.SchemaTests)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/Users/runner/runners/2.160.0/work/django/django/django/test/utils.py",
 line 370, in inner
     return func(*args, **kwargs)
   File
 "/Users/runner/runners/2.160.0/work/django/django/tests/schema/tests.py",
 line 2249, in test_db_table
     self.assertForeignKeyExists(Book, "author_id", "schema_otherauthor")
   File
 "/Users/runner/runners/2.160.0/work/django/django/tests/schema/tests.py",
 line 207, in assertForeignKeyExists
     self.assertEqual(constraint_fk, (expected_fk_table, field))
 AssertionError: Tuples differ: ('schema_author', 'id') !=
 ('schema_otherauthor', 'id')

 First differing element 0:
 'schema_author'
 'schema_otherauthor'

 - ('schema_author', 'id')
 + ('schema_otherauthor', 'id')
 ?          +++++


 ----------------------------------------------------------------------
 Ran 13209 tests in 487.293s
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30964>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.816ef7765be0278158569dc0e517b3d3%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS test failure

Django
#30964: macOS test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Simon Charette):

 Pretty sure this is related to the SQLite version installed.

 What does `python -c"import sqlite3; print(sqlite3.version_info,
 sqlite3.sqlite_version)"` yield?

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.d9aacfe7b6c25ca8cc560865f42f97e6%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS test failure

Django
In reply to this post by Django
#30964: macOS test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Simon Charette):

 Probably want to `brew install sqlite` as well at
 https://github.com/codingjoe/django/blob/f67edd20b80de813d55f5df79c0d0c6134e8b754/.github/workflows/ci.yml#L52

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.bcb1b01032821faf23ce936190a4fb16%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS test failure

Django
In reply to this post by Django
#30964: macOS test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:  needsinfo
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 This passed for me with SQLite 3.24, so I'm going to close assuming that
 the SQLite version is the underlying cause.

 It's probably `invalid` but I'll give it a `needsinfo` since
 7444f3252757ed4384623e5afd7dcfeef3e0c74e added a `check_sqlite_version()`
 which raises `if Database.sqlite_version_info < (3, 8, 3)`  — so the
 version in play must be higher that that — maybe there's room for a
 cleanup here, if you can follow-up Joe 🤔
 (No worries if not.)

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.3a7d83bffee3d7c1ffdb95f95c908df5%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure (was: macOS test failure)

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:  needsinfo
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.c4a21f479e681b6bd4ef5896095288d8%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Johannes Hoppe):

 * status:  closed => new
 * resolution:  needsinfo =>


Comment:

 Hold your horses, it's version 3.28.0 which should be supported, right?


 {{{
 Run python -c "import sqlite3; print(sqlite3.sqlite_version)"
 3.28.0
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.9db23c2acfb5d06cb4e66c2fcfd06b8f%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

 * cc: Simon Charette (added)


Comment:

 It should indeed be supported but I can't reproduce on macOS Mojave with
 3.28.0.

 Did `brew install sqlite` help anyhow?

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.79c738aecea0d3183f412437cb89d920%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Johannes Hoppe):

 @Simon

 {{{
 $ brew update
 $ brew install sqlite
 Warning: sqlite 3.30.1 is already installed and up-to-date
 To reinstall 3.30.1, run `brew reinstall sqlite`
 }}}

 Interestingly enough `sqlite3.sqlite_version` is still 3.28.0.
 In am not 100% sure this is a sqlite issue. This could also be something
 OS related. Which would make sense considering that it apears to happen
 only on macOS.

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.b13a545500273acea3c606c636dc1554%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Johannes Hoppe):

 * version:  2.2 => master


--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.e8af88d362309cf7d6b5ea9e8026567d%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson):

 Hey Joe:

 > Interestingly enough sqlite3.sqlite_version is still 3.28.0.

 You have to tell Python where to find your SQLite. The internet suggests
 LD_LIBRARY_PATH, but on macOS I find you have to set DYLD_LIBRARY_PATH:

 {{{
     export DYLD_LIBRARY_PATH=/opt/homebrew/Cellar/sqlite/3.28.1/lib
 }}}

 Simon has a variation on those instructions here: https://github.com/orf
 /django-docker-box/issues/25

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.07beaeab6c96f9e661085dfc9ea04f94%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #30964: macOS/SQLite test failure

Django
In reply to this post by Django
#30964: macOS/SQLite test failure
-------------------------------------+-------------------------------------
     Reporter:  Johannes Hoppe       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:  needsinfo
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 OK, I can't reproduce the issue here. I'll keep an eye on it but, short of
 more concrete steps, or someone else confirming, I'm not sure what we can
 do.

--
Ticket URL: <https://code.djangoproject.com/ticket/30964#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.57386ee8218d9102d940de7f844bf091%40djangoproject.com.