[Django] #31056: Add ability to override "async unsafe" checks

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #31056: Add ability to override "async unsafe" checks

Django
#31056: Add ability to override "async unsafe" checks
-----------------------------------------+-------------------------------
               Reporter:  Andrew Godwin  |          Owner:  Andrew Godwin
                   Type:  New feature    |         Status:  assigned
              Component:  Core (Other)   |        Version:  3.0
               Severity:  Normal         |       Keywords:
           Triage Stage:  Unreviewed     |      Has patch:  0
    Needs documentation:  0              |    Needs tests:  0
Patch needs improvement:  0              |  Easy pickings:  0
                  UI/UX:  0              |
-----------------------------------------+-------------------------------
 It's been reported that Jupyter, at least, executes apparently-synchronous
 code in an async environment (https://forum.djangoproject.com/t/is-there-a
 -way-to-disable-the-synchronousonlyoperation-check-when-using-the-orm-in-a
 -jupyter-notebook/548/3) and we're going to have people running headlong
 into this soon.

 The "right" way of wrapping code in sync_to_async works, but is an undue
 burden on notebook authors as it would have to be in every cell, so it's
 suggested that we add a flag that disables the async-unsafe check. Either
 a setting or an environment variable could work; I slightly prefer an
 environment variable (as it's hard to forget about) provided this works
 well with Jupyter.

--
Ticket URL: <https://code.djangoproject.com/ticket/31056>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/055.b68ad84a2395306e94bd3b0f321c0efa%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks

Django
#31056: Add ability to override "async unsafe" checks
-------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin  |                    Owner:  Andrew Godwin
         Type:  New feature    |                   Status:  assigned
    Component:  Core (Other)   |                  Version:  3.0
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+-----------------------------------------
Changes (by Andrew Godwin):

 * has_patch:  0 => 1


Comment:

 Pull request: https://github.com/django/django/pull/12172

--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.e90f772e82695fd8f8008e7a5448e9c5%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks

Django
In reply to this post by Django
#31056: Add ability to override "async unsafe" checks
-------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin  |                    Owner:  Andrew Godwin
         Type:  New feature    |                   Status:  assigned
    Component:  Core (Other)   |                  Version:  3.0
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+-----------------------------------------
Changes (by Andrew Godwin):

 * stage:  Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.7ec2090c65b060f0b4a8e1fed2055cae%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks. (was: Add ability to override "async unsafe" checks)

Django
In reply to this post by Django
#31056: Add ability to override "async unsafe" checks.
-------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin  |                    Owner:  Andrew Godwin
         Type:  New feature    |                   Status:  assigned
    Component:  Core (Other)   |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+-----------------------------------------
Changes (by felixxm):

 * has_patch:  1 => 0
 * version:  3.0 => master


--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.c7872dd3fe56dd68e1a05321456292ce%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks.

Django
In reply to this post by Django
#31056: Add ability to override "async unsafe" checks.
-------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin  |                    Owner:  Andrew Godwin
         Type:  New feature    |                   Status:  assigned
    Component:  Core (Other)   |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+-----------------------------------------
Changes (by felixxm):

 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.3ddebc2ae267d0f4a08c646dc9cd397e%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks.

Django
In reply to this post by Django
#31056: Add ability to override "async unsafe" checks.
---------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin    |                    Owner:  Andrew Godwin
         Type:  Bug              |                   Status:  assigned
    Component:  Core (Other)     |                  Version:  master
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+-----------------------------------------
Changes (by felixxm):

 * type:  New feature => Bug
 * severity:  Normal => Release blocker


--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.34f091ac13c0971601120ebfdff56105%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks.

Django
In reply to this post by Django
#31056: Add ability to override "async unsafe" checks.
---------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin    |                    Owner:  Andrew Godwin
         Type:  Bug              |                   Status:  closed
    Component:  Core (Other)     |                  Version:  master
     Severity:  Release blocker  |               Resolution:  fixed
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+-----------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9243435b5e7e327d0e1e1271b6dfd4c74ca7120b" 9243435b]:
 {{{
 #!CommitTicketReference repository=""
 revision="9243435b5e7e327d0e1e1271b6dfd4c74ca7120b"
 [3.0.x] Fixed #31056 -- Allowed disabling async-unsafe check with an
 environment variable.

 Backport of c90ab30fa1305481024b9c3c50b5a6ed6cd9a2f5 from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.f6a4e8cfcfba8f61ce32d3b1ed9801cd%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #31056: Add ability to override "async unsafe" checks.

Django
In reply to this post by Django
#31056: Add ability to override "async unsafe" checks.
---------------------------------+-----------------------------------------
     Reporter:  Andrew Godwin    |                    Owner:  Andrew Godwin
         Type:  Bug              |                   Status:  closed
    Component:  Core (Other)     |                  Version:  master
     Severity:  Release blocker  |               Resolution:  fixed
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+-----------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"c90ab30fa1305481024b9c3c50b5a6ed6cd9a2f5" c90ab30f]:
 {{{
 #!CommitTicketReference repository=""
 revision="c90ab30fa1305481024b9c3c50b5a6ed6cd9a2f5"
 Fixed #31056 -- Allowed disabling async-unsafe check with an environment
 variable.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31056#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.38191d9b577a5e2e8c2568f63bbc252b%40djangoproject.com.