[Django] #32618: Aggregation documentation should mention conditional aggregation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Django] #32618: Aggregation documentation should mention conditional aggregation

Django
#32618: Aggregation documentation should mention conditional aggregation
------------------------------------------+------------------------
               Reporter:  Simon Willison  |          Owner:  nobody
                   Type:  Bug             |         Status:  new
              Component:  Documentation   |        Version:  3.2
               Severity:  Normal          |       Keywords:
           Triage Stage:  Unreviewed      |      Has patch:  0
    Needs documentation:  1               |    Needs tests:  0
Patch needs improvement:  0               |  Easy pickings:  0
                  UI/UX:  0               |
------------------------------------------+------------------------
 I couldn't find a reference to
 https://docs.djangoproject.com/en/3.1/ref/models/conditional-expressions
 /#conditional-aggregation anywhere on
 https://docs.djangoproject.com/en/3.1/topics/db/aggregation/

--
Ticket URL: <https://code.djangoproject.com/ticket/32618>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/049.60cc5acd9d98aa33d3766e029639c8b7%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #32618: Aggregation documentation should mention conditional aggregation

Django
#32618: Aggregation documentation should mention conditional aggregation
--------------------------------+--------------------------------------
     Reporter:  Simon Willison  |                    Owner:  nobody
         Type:  Bug             |                   Status:  new
    Component:  Documentation   |                  Version:  3.2
     Severity:  Normal          |               Resolution:
     Keywords:                  |             Triage Stage:  Unreviewed
    Has patch:  0               |      Needs documentation:  1
  Needs tests:  0               |  Patch needs improvement:  0
Easy pickings:  0               |                    UI/UX:  0
--------------------------------+--------------------------------------

Comment (by Simon Willison):

 I found one mention here:
 https://docs.djangoproject.com/en/3.1/topics/db/aggregation/#filtering-on-
 annotations

--
Ticket URL: <https://code.djangoproject.com/ticket/32618#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.e4e7f76b6fc8427183a9402fe9ad3dfc%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #32618: Aggregation documentation should mention conditional aggregation

Django
In reply to this post by Django
#32618: Aggregation documentation should mention conditional aggregation
--------------------------------------+------------------------------------
     Reporter:  Simon Willison        |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Documentation         |                  Version:  3.2
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

 * needs_docs:  1 => 0
 * type:  Bug => Cleanup/optimization
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 There is also an example in the
 [https://docs.djangoproject.com/en/3.1/topics/db/aggregation/#cheat-sheet
 Cheat sheet]. A small reference should be enough, e.g.
 {{{
 diff --git a/docs/topics/db/aggregation.txt
 b/docs/topics/db/aggregation.txt
 index cc6310052a..2e882e2a1a 100644
 --- a/docs/topics/db/aggregation.txt
 +++ b/docs/topics/db/aggregation.txt
 @@ -354,7 +354,7 @@ authors with a count of highly rated books::
      >>> Author.objects.annotate(num_books=Count('book'),
 highly_rated_books=highly_rated)

  Each ``Author`` in the result set will have the ``num_books`` and
 -``highly_rated_books`` attributes.
 +``highly_rated_books`` attributes. See also :ref:`conditional-
 aggregation`.

  .. admonition:: Choosing between ``filter`` and ``QuerySet.filter()``
 }}}

 What do you think?

--
Ticket URL: <https://code.djangoproject.com/ticket/32618#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.4b5f2dd3156c9dc662eb56ed6c69a8bd%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #32618: Aggregation documentation should mention conditional aggregation

Django
In reply to this post by Django
#32618: Aggregation documentation should mention conditional aggregation
-------------------------------------+-------------------------------------
     Reporter:  Simon Willison       |                    Owner:  Hasan
         Type:                       |  Ramezani
  Cleanup/optimization               |                   Status:  assigned
    Component:  Documentation        |                  Version:  3.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned
 * has_patch:  0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32618#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.162fca31e5780be4016bae8efd1aa66e%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #32618: Aggregation documentation should mention conditional aggregation

Django
In reply to this post by Django
#32618: Aggregation documentation should mention conditional aggregation
-------------------------------------+-------------------------------------
     Reporter:  Simon Willison       |                    Owner:  Hasan
         Type:                       |  Ramezani
  Cleanup/optimization               |                   Status:  closed
    Component:  Documentation        |                  Version:  3.2
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1351f2ee163145df2cf5471eb3e57289f8853512" 1351f2e]:
 {{{
 #!CommitTicketReference repository=""
 revision="1351f2ee163145df2cf5471eb3e57289f8853512"
 Fixed #32618 -- Added link to conditional aggregation in aggregation topic
 guide.
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32618#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.4d23736c866d8cc21fc860837ab5f951%40djangoproject.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Django] #32618: Aggregation documentation should mention conditional aggregation

Django
In reply to this post by Django
#32618: Aggregation documentation should mention conditional aggregation
-------------------------------------+-------------------------------------
     Reporter:  Simon Willison       |                    Owner:  Hasan
         Type:                       |  Ramezani
  Cleanup/optimization               |                   Status:  closed
    Component:  Documentation        |                  Version:  3.2
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"078bcd587dd0b4cc395713be02c38549f5fe65e3" 078bcd58]:
 {{{
 #!CommitTicketReference repository=""
 revision="078bcd587dd0b4cc395713be02c38549f5fe65e3"
 [3.2.x] Fixed #32618 -- Added link to conditional aggregation in
 aggregation topic guide.

 Backport of 1351f2ee163145df2cf5471eb3e57289f8853512 from main
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32618#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.0577bf5812696e8fdbdbb647358436a2%40djangoproject.com.