First ASGI pull request is ready for review

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

First ASGI pull request is ready for review

Andrew Godwin-3
Hi everyone,

Just wanted to drop a note and say that the first pull request in the series needed to enable async in Django is now ready for review: https://github.com/django/django/pull/11209

This is a very minimal amount of work to get Django async-safe and understanding ASGI as an application interface, but the idea is to land this so it's definitely in 3.0, and then work on getting async abilities down to views before the 3.0 feature freeze if we can.

Once those two things are down, we can then expand the effort out a lot more and have some work for new contributors to get their teeth into, as we can then start making all the other parts of Django async-capable as a parallel effort.

Reviews and comments on the PR are encouraged; I want to make sure this is not going to hurt existing sync Django when it lands, and that it's a useful stepping stone towards async in views.

Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1uqxeLhs1bCpZLVuTFbC0S1bEKrbvjWWVvxGQCCtm0ddkg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Curtis Maloney-2
I cannot find emoji enough to express how much I appreciate the work
you've put into this :)

--
Curtis


On 4/25/19 6:50 AM, Andrew Godwin wrote:

> Hi everyone,
>
> Just wanted to drop a note and say that the first pull request in the
> series needed to enable async in Django is now ready for review:
> https://github.com/django/django/pull/11209
>
> This is a very minimal amount of work to get Django async-safe and
> understanding ASGI as an application interface, but the idea is to land
> this so it's definitely in 3.0, and then work on getting async abilities
> down to views before the 3.0 feature freeze if we can.
>
> Once those two things are down, we can then expand the effort out a lot
> more and have some work for new contributors to get their teeth into, as
> we can then start making all the other parts of Django async-capable as
> a parallel effort.
>
> Reviews and comments on the PR are encouraged; I want to make sure this
> is not going to hurt existing sync Django when it lands, and that it's a
> useful stepping stone towards async in views.
>
> Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/dcfe51af-8e6c-ca1e-cf12-6409b93720db%40tinbrain.net.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Andrew Godwin-3
In reply to this post by Andrew Godwin-3
So, it looks like most of the comments on this PR have happened and been resolved - unless anyone has any objections, I will merge it in after a couple more days (just in time for PyCon US).

Andrew

On Wed, Apr 24, 2019 at 1:50 PM Andrew Godwin <[hidden email]> wrote:
Hi everyone,

Just wanted to drop a note and say that the first pull request in the series needed to enable async in Django is now ready for review: https://github.com/django/django/pull/11209

This is a very minimal amount of work to get Django async-safe and understanding ASGI as an application interface, but the idea is to land this so it's definitely in 3.0, and then work on getting async abilities down to views before the 3.0 feature freeze if we can.

Once those two things are down, we can then expand the effort out a lot more and have some work for new contributors to get their teeth into, as we can then start making all the other parts of Django async-capable as a parallel effort.

Reviews and comments on the PR are encouraged; I want to make sure this is not going to hurt existing sync Django when it lands, and that it's a useful stepping stone towards async in views.

Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1uoyQb_f2fbEaYfDHDgJL-L_oazV74Pa-5gaF8GXiQRoTQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Mariusz Felisiak
Thanks for this patch. Can you add a trac ticket? also Can you give me & Carlton few days for review? I should be able to do this somewhere in the next week.

Are we going to create "Async" DEP?

Best,
Mariusz

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/1b122b3f-ac07-4f7b-8277-6f77ed65e827%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Andrew Godwin-3


On Tue, Apr 30, 2019 at 11:34 PM Mariusz Felisiak <[hidden email]> wrote:
Thanks for this patch. Can you add a trac ticket? also Can you give me & Carlton few days for review? I should be able to do this somewhere in the next week.

I can indeed. I wasn't sure if you wanted to get around to reviewing it or not, but take all the time you need to review. I'm sure there's some more in there that could be tightened up.

(Forgive me if I seem like I am being pushy - just trying to make sure we keep forward progress!)
 

Are we going to create "Async" DEP?


We probably should do now there is a more solid plan - the discussion on the mailing list from before was only really about this first step, not about what it would look like to adopt this more fully. I don't think the solid agreement from before means we get to skip writing this up, and from here on out it becomes much more of a new feature than merely adding safety and a new handler.

Andrew 

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1urbURE-v2wtts49or54OD-ui%3DWEKVaZY%2BFUk9xQbOsu1Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Carlton Gibson-3
Yes, I’ll review properly first half of next week. 

For the DEP, can you break out how and where people might input. There’s massive interest. 🙂

Great work as ever Andrew. Thank you so much!

C.

On Wed, 1 May 2019 at 08:46, Andrew Godwin <[hidden email]> wrote:


On Tue, Apr 30, 2019 at 11:34 PM Mariusz Felisiak <[hidden email]> wrote:
Thanks for this patch. Can you add a trac ticket? also Can you give me & Carlton few days for review? I should be able to do this somewhere in the next week.

I can indeed. I wasn't sure if you wanted to get around to reviewing it or not, but take all the time you need to review. I'm sure there's some more in there that could be tightened up.

(Forgive me if I seem like I am being pushy - just trying to make sure we keep forward progress!)
 

Are we going to create "Async" DEP?


We probably should do now there is a more solid plan - the discussion on the mailing list from before was only really about this first step, not about what it would look like to adopt this more fully. I don't think the solid agreement from before means we get to skip writing this up, and from here on out it becomes much more of a new feature than merely adding safety and a new handler.

Andrew 

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1urbURE-v2wtts49or54OD-ui%3DWEKVaZY%2BFUk9xQbOsu1Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJwKpyR4yME8VyMKrSaFZGkvZdOuh4eQiX6u74Vm-4UFEWs%2Bvw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Elad Yaniv
Exciting stuff! 
does this mean that django 3.0 COULD  compete with frontend js frameworks ? (angular react vue) 
if the answer is yes  i will be a very happy developer 

Great work!
Elad.


On Wed, May 1, 2019 at 9:55 AM Carlton Gibson <[hidden email]> wrote:
Yes, I’ll review properly first half of next week. 

For the DEP, can you break out how and where people might input. There’s massive interest. 🙂

Great work as ever Andrew. Thank you so much!

C.

On Wed, 1 May 2019 at 08:46, Andrew Godwin <[hidden email]> wrote:


On Tue, Apr 30, 2019 at 11:34 PM Mariusz Felisiak <[hidden email]> wrote:
Thanks for this patch. Can you add a trac ticket? also Can you give me & Carlton few days for review? I should be able to do this somewhere in the next week.

I can indeed. I wasn't sure if you wanted to get around to reviewing it or not, but take all the time you need to review. I'm sure there's some more in there that could be tightened up.

(Forgive me if I seem like I am being pushy - just trying to make sure we keep forward progress!)
 

Are we going to create "Async" DEP?


We probably should do now there is a more solid plan - the discussion on the mailing list from before was only really about this first step, not about what it would look like to adopt this more fully. I don't think the solid agreement from before means we get to skip writing this up, and from here on out it becomes much more of a new feature than merely adding safety and a new handler.

Andrew 

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1urbURE-v2wtts49or54OD-ui%3DWEKVaZY%2BFUk9xQbOsu1Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJwKpyR4yME8VyMKrSaFZGkvZdOuh4eQiX6u74Vm-4UFEWs%2Bvw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAO3nhSsZ1ep_VO425kUb8_rMabe9RwWf1Tk%3D2CmhriZqqQRtDw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: First ASGI pull request is ready for review

Andrew Godwin-2
This is quite unrelated to frontend - I'll explain more of the impact and potential impact in the DEP when I write it up.

Andrew

On Wed, 1 May 2019, 08:30 Elad Yaniv, <[hidden email]> wrote:
Exciting stuff! 
does this mean that django 3.0 COULD  compete with frontend js frameworks ? (angular react vue) 
if the answer is yes  i will be a very happy developer 

Great work!
Elad.


On Wed, May 1, 2019 at 9:55 AM Carlton Gibson <[hidden email]> wrote:
Yes, I’ll review properly first half of next week. 

For the DEP, can you break out how and where people might input. There’s massive interest. 🙂

Great work as ever Andrew. Thank you so much!

C.

On Wed, 1 May 2019 at 08:46, Andrew Godwin <[hidden email]> wrote:


On Tue, Apr 30, 2019 at 11:34 PM Mariusz Felisiak <[hidden email]> wrote:
Thanks for this patch. Can you add a trac ticket? also Can you give me & Carlton few days for review? I should be able to do this somewhere in the next week.

I can indeed. I wasn't sure if you wanted to get around to reviewing it or not, but take all the time you need to review. I'm sure there's some more in there that could be tightened up.

(Forgive me if I seem like I am being pushy - just trying to make sure we keep forward progress!)
 

Are we going to create "Async" DEP?


We probably should do now there is a more solid plan - the discussion on the mailing list from before was only really about this first step, not about what it would look like to adopt this more fully. I don't think the solid agreement from before means we get to skip writing this up, and from here on out it becomes much more of a new feature than merely adding safety and a new handler.

Andrew 

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1urbURE-v2wtts49or54OD-ui%3DWEKVaZY%2BFUk9xQbOsu1Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJwKpyR4yME8VyMKrSaFZGkvZdOuh4eQiX6u74Vm-4UFEWs%2Bvw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAO3nhSsZ1ep_VO425kUb8_rMabe9RwWf1Tk%3D2CmhriZqqQRtDw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1urwjtOJrZRJRHF2TpXB1eP2ccjg-GAXchGA%3DbuZ5U288g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.