Heads-up (esp. Thomas) - eyes needed on 74c10b3c

[Fernando Perez]

Howdy,

after an insane 5 weeks (lots of good news for IPython, I'll try to
post a summary soon), I'm trying to catch up on the backlog, and
yesterday merged several PRs.  In particular,
https://github.com/ipython/ipython/pull/1538, which unfortunately I
failed to notice broke the py3 builds.

Fortunately thanks to Thomas' setup of shining panda, I got a warning
very quickly (it will be great when we can trigger these builds *pre*
merging with something like the sympy bot/github integration).  So
I've just pushed a quick emergency commit which (I did test) fixes
installation and the full test suite on python3:

https://github.com/ipython/ipython/commit/74c10b3c03e377612b54eac8eb19fe0c95930683

but I'd like in particular Thomas to have a look in case there's
anything specific to our py3 machinery I should/could have done
differently.  I think it's OK, but since I don't use py3 regularly, a
bit of review would be good (and  in any case, for these kinds of
unreviewed emergency commits, post-hoc review is always a good
practice).

Cheers,

f
_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev

[Thomas Kluyver-2]

On 14 April 2012 10:17, Fernando Perez <[hidden email]> wrote:
> https://github.com/ipython/ipython/commit/74c10b3c03e377612b54eac8eb19fe0c95930683
>
> but I'd like in particular Thomas to have a look in case there's
> anything specific to our py3 machinery I should/could have done
> differently.  I think it's OK, but since I don't use py3 regularly, a
> bit of review would be good (and  in any case, for these kinds of
> unreviewed emergency commits, post-hoc review is always a good
> practice).

We're interpolating a bytes string into a regular string, which
doesn't quite work as expected:

commit = "b'816e3fa'"

We'll need to explicitly decode it first.

Apart from that, since the file should always be pure ASCII, it should
be possible to use the built in open() function, rather than
io.open(), and avoid having to do map(unicode, ...).

I'll prepare a small PR to add to our stack ;-)

Thomas
_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev

[Min RK]

On Sat, Apr 14, 2012 at 10:21, Thomas Kluyver <[hidden email]> wrote:

On 14 April 2012 10:17, Fernando Perez <[hidden email]> wrote:
> https://github.com/ipython/ipython/commit/74c10b3c03e377612b54eac8eb19fe0c95930683
>
> but I'd like in particular Thomas to have a look in case there's
> anything specific to our py3 machinery I should/could have done
> differently.  I think it's OK, but since I don't use py3 regularly, a
> bit of review would be good (and  in any case, for these kinds of
> unreviewed emergency commits, post-hoc review is always a good
> practice).

We're interpolating a bytes string into a regular string, which
doesn't quite work as expected:

commit = "b'816e3fa'"

We'll need to explicitly decode it first.

Apart from that, since the file should always be pure ASCII, it should
be possible to use the built in open() function, rather than
io.open(), and avoid having to do map(unicode, ...).

I'll prepare a small PR to add to our stack ;-)

Yes, I imagine just using builtin open and str literals is the right way to go. No need to deal with unicode for two lines of ascii text.  I just got carried away with our recently discovery that we should use io.open everywhere (clearly that excludes setup).

 

Thomas

_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev

_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev

[Thomas Kluyver-2]

On 14 April 2012 19:38, MinRK <[hidden email]> wrote:
> I just got carried away with our recently discovery that we should use
> io.open everywhere (clearly that excludes setup).

I think it's a sensible approach, even in setup, if we had to handle
non-ascii characters - but thankfully we don't.

Thomas
_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev

[Min RK]

On Sat, Apr 14, 2012 at 11:50, Thomas Kluyver <[hidden email]> wrote:

On 14 April 2012 19:38, MinRK <[hidden email]> wrote:
> I just got carried away with our recently discovery that we should use
> io.open everywhere (clearly that excludes setup).

I think it's a sensible approach, even in setup, if we had to handle
non-ascii characters - but thankfully we don't.

Sure - if we were doing real arbitrary text handling, but two lines of ascii text is not that, and your PR is the right approach.  No need to solve problems we don't have.

 

Thomas
_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev

_______________________________________________
IPython-dev mailing list
[hidden email]
http://mail.scipy.org/mailman/listinfo/ipython-dev