Loading lzma compressed fixtures

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Loading lzma compressed fixtures

Paolo Melchiorre
Hi all,

Working at my latest merged PR [1] in Django I saw in the code the lack
of support for lzma compressed fixture for loaddata command so I opened
a ticket [2] and a related PR [3].

I think is a small PR to accept before Django 3.1 feature freeze but it
can be a great improvement in loading big fixtures.

I would ask someone to review my PR [3].

Thanks,
Paolo


[1] https://github.com/django/django/pull/12871
[2] https://code.djangoproject.com/ticket/31552
[3] https://github.com/django/django/pull/12879

--
https://www.paulox.net

--
You received this message because you are subscribed to the Google Groups "Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/c8893560-de46-05d2-66d9-42f11f4cb2d5%40melchiorre.org.
Reply | Threaded
Open this post in threaded view
|

Re: Loading lzma compressed fixtures

Tim Graham-2
Hi Paolo, Please don't ask for code reviews on this mailing list. It just adds noise. Patches are reviewed from "Patches needing review" at https://dashboard.djangoproject.com/. At this time there are ~30 patches in the queue. Requesting your feature to be moved to the front of the review queue the weekend before the feature freeze isn't appropriate.

On Saturday, May 9, 2020 at 6:22:13 AM UTC-4, Paolo Melchiorre wrote:
Hi all,

Working at my latest merged PR [1] in Django I saw in the code the lack
of support for lzma compressed fixture for loaddata command so I opened
a ticket [2] and a related PR [3].

I think is a small PR to accept before Django 3.1 feature freeze but it
can be a great improvement in loading big fixtures.

I would ask someone to review my PR [3].

Thanks,
Paolo


[1] <a href="https://github.com/django/django/pull/12871" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F12871\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE_oJQg0sq0LVVpRZRTxUwTuGVItw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F12871\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE_oJQg0sq0LVVpRZRTxUwTuGVItw&#39;;return true;">https://github.com/django/django/pull/12871
[2] <a href="https://code.djangoproject.com/ticket/31552" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fcode.djangoproject.com%2Fticket%2F31552\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHc7oUG7-O2CPI-piENFkx2ooF8Ow&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fcode.djangoproject.com%2Fticket%2F31552\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHc7oUG7-O2CPI-piENFkx2ooF8Ow&#39;;return true;">https://code.djangoproject.com/ticket/31552
[3] <a href="https://github.com/django/django/pull/12879" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F12879\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGxwnWDWwLgG62tpZR5o1cuEyHw0w&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F12879\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGxwnWDWwLgG62tpZR5o1cuEyHw0w&#39;;return true;">https://github.com/django/django/pull/12879

--
<a href="https://www.paulox.net" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwww.paulox.net\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNErBKRwx98ofxsqEVnr5YzNfFouaA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwww.paulox.net\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNErBKRwx98ofxsqEVnr5YzNfFouaA&#39;;return true;">https://www.paulox.net

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/070f2da9-bf9c-4798-8cb5-64e3f91723f0%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Loading lzma compressed fixtures

Paolo Melchiorre
On 09/05/20 12:39, Tim Graham wrote:

> On Saturday, May 9, 2020 at 6:22:13 AM UTC-4, Paolo Melchiorre wrote:
>> Working at my latest merged PR [1] in Django I saw in the code the lack
>> of support for lzma compressed fixture for loaddata command so I opened
>> a ticket [2] and a related PR [3].
>> I think is a small PR to accept before Django 3.1 feature freeze but it
>> can be a great improvement in loading big fixtures.
>> I would ask someone to review my PR [3].
>> [1] https://github.com/django/django/pull/12871
>> [2] https://code.djangoproject.com/ticket/31552
>> [3] https://github.com/django/django/pull/12879
> Hi Paolo, Please don't ask for code reviews on this mailing list. It
> just adds noise. Patches are reviewed from "Patches needing review" at
> https://dashboard.djangoproject.com/. At this time there are ~30 patches
> in the queue. Requesting your feature to be moved to the front of
> the review queue the weekend before the feature freeze isn't appropriate.

Hi Tim,

Sorry, I wasn't aware of the dashboard and I definitely didn't want to
ask my feature to be moved to the front of the review queue.

Next time I won't ask for code reviews on this mailing list.

Thanks,
Paolo
--
https://www.paulox.net

--
You received this message because you are subscribed to the Google Groups "Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/77a9f90e-d934-b23b-fe71-e3a6d421adba%40melchiorre.org.