thank you everybody for the good job on this. I have tested Oliver's view_permission_master branch with two of my projects and it works like expected:
- User was only able to *view* models
- Search and list filters remained completely functional
- InlineModelAdmins only showed up if the "view" permission was there for the relevant models
So far, so good. I have found only one issue: when using a TabularInline instead of a StackedInline I am getting an exception (KeyError in admin/helpers.py:286). I think this is due to the fact that in `InlineAdminFormSet` you only assign the fieldset fields to `viewonly_fields`. But I think this should be an easy fix.
I am in desperate need of the "view" permission feature for several projects, so it would be really cool if this could be merged. I also know from other Django users out there that this is an important and wanted feature. Since the original PR is over two years old I am wondering what the reasons are for not accepting it? Could anyone from the Django dev team comment on this please?
Am Dienstag, 5. Dezember 2017 22:51:17 UTC+1 schrieb Olivier Dalang:
Just wanted to draw attention towards <a href="https://github.com/django/django/pull/6734" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F6734\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFEnlmTDGiO7VBzZhKFDrNFEmXALw';return true;" onclick="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F6734\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFEnlmTDGiO7VBzZhKFDrNFEmXALw';return true;">PR 6734 that adds a view permission to Django admin (original work done by PetrDlouhy). I was hoping to get it merged for 1.11, then 2.0.
I just merged in the new code, and now there's some tests failing again.
If I fix those, will it get merged ? I'm not familiar with Django's dev process, but I think this checked all the boxes (PR reviewed, tests, doc, other user's support, etc...).