Poll - Fwd: [Bug 858304] [NEW] variable name is highighted on LHS of equality (==) test, but shouldn't be

[Andreas Röhler-2]

Hi folks,

possibility of highlighting variable name is a new feature in the trunk.

It's not clear however, in which circumstances variable should get
highlighted -if at all.

Also might drop that, should it not be considered useful.

Would be nice to get some comments before a release.

Thanks,

Andreas



-------- Original-Nachricht --------
Betreff: [Bug 858304] [NEW] variable name is highighted on LHS of
equality (==) test, but shouldn't be
Datum: Sat, 24 Sep 2011 15:58:38 -0000
Von: Andrew Uzilov <[hidden email]>
Antwort an: Bug 858304 <[hidden email]>
An: [hidden email]

Public bug reported:

This pertains to the lp:python-mode branch, I think this bug does not
occur in 6.0.2.

LHS of equality (==) tests now gets highlighted, but it shouldn't.  The
highlighting should only be for LHS on assignment (=) expressions.  For
example:

if someVar == 5:
      doSomething()

"someVar" is highlighted.  However, if you wrap it with something, like
this:

if len (someVar) == 5:
      doSomething()

"someVar" is not highlighted.

** Affects: python-mode
      Importance: Undecided
          Status: New

--
You received this bug notification because you are subscribed to python-
mode.el.
https://bugs.launchpad.net/bugs/858304

Title:
   variable name is highighted on LHS of equality (==) test, but
   shouldn't be

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-mode/+bug/858304/+subscriptions

_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

[Georg Brandl-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Andreas,

if anything is highlighted, then it should be only locals at assignment.
Highlighting other assignments gets much too messy on the eyes (and if you
start highlighting "variable" (no such thing in Python anyway) names
on access too, you will have to color most of the code...

Georg

Am 25.09.2011 18:47, schrieb Andreas Röhler:

> Hi folks,
>
> possibility of highlighting variable name is a new feature in the trunk.
>
> It's not clear however, in which circumstances variable should get
> highlighted -if at all.
>
> Also might drop that, should it not be considered useful.
>
> Would be nice to get some comments before a release.
>
> Thanks,
>
> Andreas
>
>
>
> -------- Original-Nachricht -------- Betreff: [Bug 858304] [NEW] variable
> name is highighted on LHS of equality (==) test, but shouldn't be Datum:
> Sat, 24 Sep 2011 15:58:38 -0000 Von: Andrew Uzilov
> <[hidden email]> Antwort an: Bug 858304
> <[hidden email]> An: [hidden email]
>
> Public bug reported:
>
> This pertains to the lp:python-mode branch, I think this bug does not occur
> in 6.0.2.
>
> LHS of equality (==) tests now gets highlighted, but it shouldn't.  The
> highlighting should only be for LHS on assignment (=) expressions.  For
> example:
>
> if someVar == 5: doSomething()
>
> "someVar" is highlighted.  However, if you wrap it with something, like
> this:
>
> if len (someVar) == 5: doSomething()
>
> "someVar" is not highlighted.
>
> ** Affects: python-mode Importance: Undecided Status: New
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iEYEARECAAYFAk5/XdIACgkQN9GcIYhpnLCYxQCcDzhM2l8NPm9ZgQMFlYCcbFHG
hm0AnRDSZfEX8wEpEjjFVq1V2U2LyqXq
=tTNq
-----END PGP SIGNATURE-----
_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

[Andreas Röhler-2]

Am 25.09.2011 18:58, schrieb Georg Brandl:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Andreas,
>
> if anything is highlighted, then it should be only locals at assignment.
> Highlighting other assignments gets much too messy on the eyes (and if you
> start highlighting "variable" (no such thing in Python anyway) names
> on access too, you will have to color most of the code...
>
> Georg

Hi Georg, hi Andrew,

checked in a change.

Could you have a look again?

Thanks,

Andreas
_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

[Barry Warsaw]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sep 25, 2011, at 06:58 PM, Georg Brandl wrote:

>if anything is highlighted, then it should be only locals at assignment.
>Highlighting other assignments gets much too messy on the eyes (and if you
>start highlighting "variable" (no such thing in Python anyway) names
>on access too, you will have to color most of the code...

Agreed, and personally, even highlighting assignments is too fruit salady for
me so I'm glad it can be turned off. ;)

- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOf4+kAAoJEBJutWOnSwa/CC4P/1Ka6UxRYaLXan+y9dFe5Olc
uV0tsT3HULuvi9aHgn4n2a6MrO0CChRESxp3Th3KrUHJMWaZYRhFXbTSofddC6CX
OlbeuPJJDYeiv83A5k3EXOlcUZEtp8E1sbbFF3MLNbau7wdfb2ZM/COb0OWegSf9
qNU6yzTrcvxtaJ0ro0gFT7QthEa3GB43kGnhVxie5CteAkH1/v9KbmhL876BCm9L
ysfx2dYwDqjnxezxZkTsunUci3+MSxjIBi3UJZNuwWQQY1Vh2YIOXsBQBaj78UtJ
W8VtKNeL+IIewWmMzK2jkvw8NEgwFT5QtuULK/DqaMSyuJ7hDbsq0gAAhaf76dDw
hJqBE2WDatVkGomnCQmoTZRrjd+EOLmnXgOxPE2Zr3hwLxmkJ822dDiJIjuLbi//
QbVOUxTrw/KikEOezFc+RsmpSZvCBjR2zZZWIvua2MILOGVj0/1+LWU+zs5W6rzN
cpDGHFiZc8+PZDYjtvniSG+uqZbVpMLwqbxIc2H4muThl/+X4OjTM2TnZtS1m2Dp
whYf8zkxkNcriCiXHXGIQtshWnXQJyeYCESQqBqAzYuJui4UKrNHqrU9jLyw18TC
ynAvkGwNyvOvMm0gGvHY0kEAmEGhNSnmGbPoh5pq+ij5Q/C//BcQtmagpPcgR9Pi
cZubnJpdvII2Xm0KjZ7U
=GlSw
-----END PGP SIGNATURE-----
_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

[Andreas Röhler-2]

Am 25.09.2011 22:31, schrieb Barry Warsaw:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On Sep 25, 2011, at 06:58 PM, Georg Brandl wrote:
>
>> if anything is highlighted, then it should be only locals at assignment.
>> Highlighting other assignments gets much too messy on the eyes (and if you
>> start highlighting "variable" (no such thing in Python anyway) names
>> on access too, you will have to color most of the code...
>
> Agreed, and personally, even highlighting assignments is too fruit salady for
> me so I'm glad it can be turned off. ;)
>
> - -Barry

will sett the default to nil

Andreas
_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

[Andrew V. Uzilov]

On Sun, Sep 25, 2011 at 10:20 PM, Andreas Röhler
<[hidden email]> wrote:

> Am 25.09.2011 22:31, schrieb Barry Warsaw:
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA256
>>
>> On Sep 25, 2011, at 06:58 PM, Georg Brandl wrote:
>>
>>> if anything is highlighted, then it should be only locals at assignment.
>>> Highlighting other assignments gets much too messy on the eyes (and if
>>> you
>>> start highlighting "variable" (no such thing in Python anyway) names
>>> on access too, you will have to color most of the code...
>>
>> Agreed, and personally, even highlighting assignments is too fruit salady
>> for
>> me so I'm glad it can be turned off. ;)
>>
>> - -Barry
>
> will sett the default to nil
>
> Andreas

Sorry for the naive question, but... since it's off by default, how do
I turn it back on?

Thanks,
Andrew U.
_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

[akira-11]

On 09/27/2011 10:20 PM, Andrew V. Uzilov wrote:

> On Sun, Sep 25, 2011 at 10:20 PM, Andreas Röhler
> <[hidden email]>  wrote:
>> Am 25.09.2011 22:31, schrieb Barry Warsaw:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA256
>>>
>>> On Sep 25, 2011, at 06:58 PM, Georg Brandl wrote:
>>>
>>>> if anything is highlighted, then it should be only locals at assignment.
>>>> Highlighting other assignments gets much too messy on the eyes (and if
>>>> you
>>>> start highlighting "variable" (no such thing in Python anyway) names
>>>> on access too, you will have to color most of the code...
>>> Agreed, and personally, even highlighting assignments is too fruit salady
>>> for
>>> me so I'm glad it can be turned off. ;)
>>>
>>> - -Barry
>> will sett the default to nil
>>
>> Andreas
> Sorry for the naive question, but... since it's off by default, how do
> I turn it back on?
>
> Thanks,
> Andrew U.

customize-group python Py Variable Name Face


--
akira
_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode