Re: [Ipython-svndiff] 2706 - add zope profile

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Fernando Perez
Hi all,

[ please all devs with commit rights read this message, there's an
important point at the end regarding licensing]

this contribution is very nice, thanks to Stefan for giving it.  But
I'm a bit concerned about something:4

On 9/4/07, [hidden email] <[hidden email]> wrote:

> Author: vivainio
> Date: 2007-09-04 10:13:52 -0500 (Tue, 04 Sep 2007)
> New Revision: 2706
>
> Added:
>    ipython/trunk/IPython/Extensions/ipy_profile_zope.py
> Modified:
>    ipython/trunk/doc/ChangeLog
> Log:
> add zope profile
>
> Added: ipython/trunk/IPython/Extensions/ipy_profile_zope.py
> ===================================================================
> --- ipython/trunk/IPython/Extensions/ipy_profile_zope.py        2007-09-04 15:10:37 UTC (rev 2705)
> +++ ipython/trunk/IPython/Extensions/ipy_profile_zope.py        2007-09-04 15:13:52 UTC (rev 2706)
> @@ -0,0 +1,320 @@
> +# -*- coding: utf-8 -*-
> +#
> +# File: ipy_profile_zope.py
> +#
> +# Copyright (c) InQuant GmbH
> +#
> +# An ipython profile for zope and plone. Some ideas
> +# stolen from http://www.tomster.org.
> +#
> +# German Free Software License (D-FSL)
> +#
> +# This Program may be used by anyone in accordance with the terms of the
> +# German Free Software License
> +# The License may be obtained under <http://www.d-fsl.org>.
> +
> +__author__ = """Stefan Eletzhofer <[hidden email]>"""


As per the terms of the license, given in English in:

http://www.dipp.nrw.de/d-fsl/index_html/lizenzen/en/D-FSL-1_0_en.txt

we are supposed to:

1. Ship the full text of the license as well.  This can be added to
the doc/ directory.  Currently we only have a single COPYING file that
contains the IPython license (BSD), but we could make a directory
called licenses/ and include there the various licenses for each piece
that we include, for which the author decided to use a different
license than ours.  The COPYING file would remain, with just a note at
the top (similar to what's already there) directing readers to the
licenses/ directory.

2. Provide startup info.  The license reads:

(2) If license and/or contract terms are
displayed when the Program is installed and/or
started, the following items must also be
displayed:

1. this License;

2. a reference to this License; and

3. a reference to the Entitled Person(s) to the
initial program components used under this
License.

I'm not sure if we're required to interpret that as loading the
license into the license() calls for the core.  We don't display
automatically license info at startup, it's just available to the user
if requested via license().  So I think we're OK, but I'd prefer to
clarify this with the author.

A note to all developers:

I know none of us likes to spend time on this, but we must be careful.
 In the future, before adding code that carries a *new* license into
the code (such as was this case), please FIRST send a message to -dev
so we can clarify these isuses to everyone's satisfaction, and THEN
make the commit.  There have been enough flamewars recently on various
projects (see BSD/Linux in the past week) due to well-intentioned but
sloppy handling of licensing that I want to be very careful with how
we handle code that comes with a new license into our codebase.  The
commit is already done and I think in this case we're OK, but I don't
want any surprises.

Code which is given to us with BSD/MIT/Python license is obviously OK,
since that's what we use already.

Cheers,

f
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Ville M. Vainio
On 9/4/07, Fernando Perez <[hidden email]> wrote:

> [ please all devs with commit rights read this message, there's an
> important point at the end regarding licensing]
>
> this contribution is very nice, thanks to Stefan for giving it.  But
> I'm a bit concerned about something:4

Stefan, is it ok that we relicense this instance under BSD?

> I know none of us likes to spend time on this, but we must be careful.

I don't think too much care is needed, really, esp. as far as
extensions are concerned. We can add and drop them on whim, because
distributing them is aggregation rather than linking (i.e. none of
code shipped with IPython imports them).

--
Ville M. Vainio - vivainio.googlepages.com
blog=360.yahoo.com/villevainio - g[mail | talk]='vivainio'
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Fernando Perez
On 9/4/07, Ville M. Vainio <[hidden email]> wrote:
> On 9/4/07, Fernando Perez <[hidden email]> wrote:
>
> > [ please all devs with commit rights read this message, there's an
> > important point at the end regarding licensing]
> >
> > this contribution is very nice, thanks to Stefan for giving it.  But
> > I'm a bit concerned about something:4
>
> Stefan, is it ok that we relicense this instance under BSD?

I think it's OK we leave it with his license, since in this case I
don't see a problem, as long as we include the actual license text, as
required by the license itself.

I'd also like a clarification from Stefan on the startup display
clause; as I said I think we're fine, but I want to make sure he
agrees.

> > I know none of us likes to spend time on this, but we must be careful.
>
> I don't think too much care is needed, really, esp. as far as
> extensions are concerned. We can add and drop them on whim, because
> distributing them is aggregation rather than linking (i.e. none of
> code shipped with IPython imports them).

By care I mean simply having a quick heads-up on list before we put a
new license in a commit, just so we all know it's happening at all,
and that we agree we didn't miss anything.  Even you make mistakes
sometimes :)

In this case, for example, the license *requires* the original text to
be distributed (not just a URL link) and that was not done in the
commit.  So technically, we're in violation of the license terms.  I
know it's a trivial fix right now (just adding the file), but that's
why I do NOT want license things to be done 'silently'.

Cheers,

f
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Fernando Perez
In reply to this post by Fernando Perez
Just a note: I'll be likely offline for the rest of the day (server upgrades).


f
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Ville M. Vainio
In reply to this post by Ville M. Vainio
On 9/4/07, Stefan Eletzhofer <[hidden email]> wrote:

> 2007/9/4, Ville M. Vainio <[hidden email]>:
> > On 9/4/07, Fernando Perez <[hidden email]> wrote:
> >
> > > [ please all devs with commit rights read this message, there's an
> > > important point at the end regarding licensing]
> > >
> > > this contribution is very nice, thanks to Stefan for giving it.  But
> > > I'm a bit concerned about something:4
> >
> > Stefan, is it ok that we relicense this instance under BSD?
>
> Yes. As I said, I wasn't aware of what that license really means,
> so if it involves some hassle (even including a startup teext etc.),
> then I'd surely like to drop it, also for myself. I can do that in no
> time :), or you can do it, in which case I'd like to get a short message
> such that I can have the plone collective SVN in sync.

Great! I knew this wouldn't prove to be a problem. I'll make the
modifications to our svn and give you a note.

--
Ville M. Vainio - vivainio.googlepages.com
blog=360.yahoo.com/villevainio - g[mail | talk]='vivainio'
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Ville M. Vainio
On 9/4/07, Ville M. Vainio <[hidden email]> wrote:

> Great! I knew this wouldn't prove to be a problem. I'll make the
> modifications to our svn and give you a note.

Done. Here's the changeset:

http://projects.scipy.org/ipython/ipython/changeset/2709

And here's the full file:

http://projects.scipy.org/ipython/ipython/browser/ipython/trunk/IPython/Extensions/ipy_profile_zope.py?rev=2709&format=raw

Thank you for your swift co-operation. :-)

--
Ville M. Vainio - vivainio.googlepages.com
blog=360.yahoo.com/villevainio - g[mail | talk]='vivainio'
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Ipython-svndiff] 2706 - add zope profile

Fernando Perez
In reply to this post by Ville M. Vainio
On 9/4/07, Stefan Eletzhofer <[hidden email]> wrote:

> Hi,
>
> 2007/9/4, Ville M. Vainio <[hidden email]>:
> > On 9/4/07, Fernando Perez <[hidden email]> wrote:
> >
> > > [ please all devs with commit rights read this message, there's an
> > > important point at the end regarding licensing]
> > >
> > > this contribution is very nice, thanks to Stefan for giving it.  But
> > > I'm a bit concerned about something:4
> >
> > Stefan, is it ok that we relicense this instance under BSD?
>
> Yes. As I said, I wasn't aware of what that license really means,
> so if it involves some hassle (even including a startup teext etc.),
> then I'd surely like to drop it, also for myself. I can do that in no
> time :), or you can do it, in which case I'd like to get a short message
> such that I can have the plone collective SVN in sync.

Even better!  I wasn't sure if you had hard attachments to the
original license, which is why I wanted to leave you the option of
keeping it.  But in terms of 'playing nice' with the rest of ipython's
codebase, BSD makes things vastly easier.

I see Ville just committed the changes, so all is good now.

Many thanks for both your contribution and your cooperation.

Cheers,

f

ps - offlining now, I'll try to commit my doctest and other pending
fixes later tonight.  I have work to do on a server now.
_______________________________________________
IPython-dev mailing list
[hidden email]
http://lists.ipython.scipy.org/mailman/listinfo/ipython-dev