Re: [Merge] lp:~freiksenet/python-mode/hide-show-support into lp:python-mode

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Merge] lp:~freiksenet/python-mode/hide-show-support into lp:python-mode

Andreas Röhler-2
Barry Warsaw wrote:

> On Jan 18, 2010, at 2:43 AM, Andreas Roehler wrote:
>
>> Barry Warsaw wrote:
>>> Oops, that was the wrong branch.  Andreas, please review this branch yourself and mark it approved if you want.  Then merge this branch and push it.
>> OK, merged locally. Got
>>
>> " M  python-mode.el
>> All changes applied successfully."
>>
>> Seems I have to do a commit still.
>> After this: push into the trunk?
>
> Correct.
>
> Uses --fixes when you do a commit (see 'bzr help commit') and attach the bug number.

Don't see a bug number here - it's just an extension. Going to commit without...(?)

Andreas


  Then when you push, Launchpad should update all the data.
>
>

_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode
Reply | Threaded
Open this post in threaded view
|

Re: [Merge] lp:~freiksenet/python-mode/hide-show-support into lp:python-mode

Barry Warsaw
On Jan 18, 2010, at 02:25 PM, Andreas Roehler wrote:

>Don't see a bug number here - it's just an extension. Going to commit
>without...(?)

Ah, then you don't need --fixes.  It's generally good practice in the future
to open a bug first, and link the branch to the bug.  Plus you get more karma
that way. :)

-Barry

_______________________________________________
Python-mode mailing list
[hidden email]
http://mail.python.org/mailman/listinfo/python-mode

signature.asc (852 bytes) Download Attachment