Relax system check on fields intermediary tables for db_table collision when database routers are installed

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Relax system check on fields intermediary tables for db_table collision when database routers are installed

Anonymous Rabbit
Hello there,

This regards multi-database Django.

On https://github.com/django/django/pull/11630, a change was made to allow for multiple models with the same db_name, when a DATABASE_ROUTER is present. 
A ticket was open here for that issue: https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ . Eventually it gets marked with wontfix, but with a notice: "Feel free to reopen and offer a patch for evaluation if you think the implementation is straightforward."

I implemented the same changes of PR #11630, but with fields.E340 in mind (fields.E340: The field’s intermediary table <table name> clashes with the table name of <model>/<model>.<field name>.).

I would like to open a PR for it, but I'm not sure of the process I have to follow. Should the ticket be re-opened? Can I open the PR pointing at the wontfix ticket instead? Should I open a new ticket for it?

Best regards,
Xavier

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Relax system check on fields intermediary tables for db_table collision when database routers are installed

Adam Johnson-2
Please create a new ticket with a reference to the old one, and then a PR against that, since your change is for a different check.

On Thu, 13 Feb 2020 at 12:15, Anonymous Rabbit <[hidden email]> wrote:
Hello there,

This regards multi-database Django.

On https://github.com/django/django/pull/11630, a change was made to allow for multiple models with the same db_name, when a DATABASE_ROUTER is present. 
A ticket was open here for that issue: https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ . Eventually it gets marked with wontfix, but with a notice: "Feel free to reopen and offer a patch for evaluation if you think the implementation is straightforward."

I implemented the same changes of PR #11630, but with fields.E340 in mind (fields.E340: The field’s intermediary table <table name> clashes with the table name of <model>/<model>.<field name>.).

I would like to open a PR for it, but I'm not sure of the process I have to follow. Should the ticket be re-opened? Can I open the PR pointing at the wontfix ticket instead? Should I open a new ticket for it?

Best regards,
Xavier

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com.


--
Adam

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Relax system check on fields intermediary tables for db_table collision when database routers are installed

Anonymous Rabbit
Before I move forward I just to want clarify, my changes are for the same check specified in ticket #29092. Should I still open a new ticket in lieu of re-opening #29092?

On Thu, 13 Feb 2020 at 13:23, Adam Johnson <[hidden email]> wrote:
Please create a new ticket with a reference to the old one, and then a PR against that, since your change is for a different check.

On Thu, 13 Feb 2020 at 12:15, Anonymous Rabbit <[hidden email]> wrote:
Hello there,

This regards multi-database Django.

On https://github.com/django/django/pull/11630, a change was made to allow for multiple models with the same db_name, when a DATABASE_ROUTER is present. 
A ticket was open here for that issue: https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ . Eventually it gets marked with wontfix, but with a notice: "Feel free to reopen and offer a patch for evaluation if you think the implementation is straightforward."

I implemented the same changes of PR #11630, but with fields.E340 in mind (fields.E340: The field’s intermediary table <table name> clashes with the table name of <model>/<model>.<field name>.).

I would like to open a PR for it, but I'm not sure of the process I have to follow. Should the ticket be re-opened? Can I open the PR pointing at the wontfix ticket instead? Should I open a new ticket for it?

Best regards,
Xavier

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com.


--
Adam

--
You received this message because you are subscribed to a topic in the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CADfb6NLTfKQ_h7-NovUROEK9RrYcF7UyRtcZPVrX-ZayzcHo-w%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Relax system check on fields intermediary tables for db_table collision when database routers are installed

Tim Graham-2
The change for that ticket is already released. Please open a new ticket.

On Thursday, February 13, 2020 at 9:00:35 AM UTC-5, Anonymous Rabbit wrote:
Before I move forward I just to want clarify, my changes are for the same check specified in ticket #29092. Should I still open a new ticket in lieu of re-opening #29092?

On Thu, 13 Feb 2020 at 13:23, Adam Johnson <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="KUU0EOWpFQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">m...@...> wrote:
Please create a new ticket with a reference to the old one, and then a PR against that, since your change is for a different check.

On Thu, 13 Feb 2020 at 12:15, Anonymous Rabbit <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="KUU0EOWpFQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">xav...@...> wrote:
Hello there,

This regards multi-database Django.

On <a href="https://github.com/django/django/pull/11630" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F11630\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE8IiUHEbl_-qTih3yKxSYUsngJSA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F11630\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE8IiUHEbl_-qTih3yKxSYUsngJSA&#39;;return true;">https://github.com/django/django/pull/11630, a change was made to allow for multiple models with the same db_name, when a DATABASE_ROUTER is present. 
A ticket was open here for that issue: <a href="https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ&#39;;return true;">https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ . Eventually it gets marked with wontfix, but with a notice: "Feel free to reopen and offer a patch for evaluation if you think the implementation is straightforward."

I implemented the same changes of PR #11630, but with fields.E340 in mind (fields.E340: The field’s intermediary table <table name> clashes with the table name of <model>/<model>.<field name>.).

I would like to open a PR for it, but I'm not sure of the process I have to follow. Should the ticket be re-opened? Can I open the PR pointing at the wontfix ticket instead? Should I open a new ticket for it?

Best regards,
Xavier

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="KUU0EOWpFQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">django-d...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com.


--
Adam

--
You received this message because you are subscribed to a topic in the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this topic, visit <a href="https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe&#39;;return true;">https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="KUU0EOWpFQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">django-d...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/2e38cc16-ac9c-461b-80f8-8fc3e21d6a53%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Relax system check on fields intermediary tables for db_table collision when database routers are installed

Anonymous Rabbit
Will do. Thanks.

On Thu, 13 Feb 2020 at 17:13, Tim Graham <[hidden email]> wrote:
The change for that ticket is already released. Please open a new ticket.

On Thursday, February 13, 2020 at 9:00:35 AM UTC-5, Anonymous Rabbit wrote:
Before I move forward I just to want clarify, my changes are for the same check specified in ticket #29092. Should I still open a new ticket in lieu of re-opening #29092?

On Thu, 13 Feb 2020 at 13:23, Adam Johnson <[hidden email]> wrote:
Please create a new ticket with a reference to the old one, and then a PR against that, since your change is for a different check.

On Thu, 13 Feb 2020 at 12:15, Anonymous Rabbit <[hidden email]> wrote:
Hello there,

This regards multi-database Django.

On https://github.com/django/django/pull/11630, a change was made to allow for multiple models with the same db_name, when a DATABASE_ROUTER is present. 
A ticket was open here for that issue: https://groups.google.com/forum/#!searchin/django-updates/29092%7Csort:date/django-updates/K1VuUaa9BUc/IDmjZoiRCQAJ . Eventually it gets marked with wontfix, but with a notice: "Feel free to reopen and offer a patch for evaluation if you think the implementation is straightforward."

I implemented the same changes of PR #11630, but with fields.E340 in mind (fields.E340: The field’s intermediary table <table name> clashes with the table name of <model>/<model>.<field name>.).

I would like to open a PR for it, but I'm not sure of the process I have to follow. Should the ticket be re-opened? Can I open the PR pointing at the wontfix ticket instead? Should I open a new ticket for it?

Best regards,
Xavier

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7819a6e1-3f47-41c8-a6c0-d35de3f37578%40googlegroups.com.


--
Adam

--
You received this message because you are subscribed to a topic in the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3-F2%3DBC4bGqiMpf2cG5F47Hn217DgV3YaVGc%2BK9_VWAg%40mail.gmail.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-developers/Ypks34xj1AY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/2e38cc16-ac9c-461b-80f8-8fc3e21d6a53%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CADfb6NLuVsV%3DUXOVYjYt9GvFo5jo%2B_EZWaPwLFDRVP1yviqNyw%40mail.gmail.com.