[cherrypy/cheroot] d568b3: Don't use SO_REUSEADDR on Windows

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[cherrypy/cheroot] d568b3: Don't use SO_REUSEADDR on Windows

webknjaz
  Branch: refs/heads/master
  Home:   https://github.com/cherrypy/cheroot
  Commit: d568b3972de1da30a985082b3a9f75812c55d31c
      https://github.com/cherrypy/cheroot/commit/d568b3972de1da30a985082b3a9f75812c55d31c
  Author: Johannes Löthberg <[hidden email]>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M cheroot/server.py

  Log Message:
  -----------
  Don't use SO_REUSEADDR on Windows

On Windows the SO_REUSEADDR sockopt has different semantics, so we don't
want to enable it there.

See https://msdn.microsoft.com/en-us/library/ms740621(v=vs.85).aspx

Fixes cherrypy/cherrypy#1088

Signed-off-by: Johannes Löthberg <[hidden email]>


  Commit: 9340823c85431fba5d1633b8e1c0e35c13506444
      https://github.com/cherrypy/cheroot/commit/9340823c85431fba5d1633b8e1c0e35c13506444
  Author: Johannes Löthberg <[hidden email]>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M cheroot/server.py

  Log Message:
  -----------
  Add comment about Windows' different REUSEADDR semantics

Signed-off-by: Johannes Löthberg <[hidden email]>


  Commit: 5c71635ee03083eca502a62383ccb4b61d713d74
      https://github.com/cherrypy/cheroot/commit/5c71635ee03083eca502a62383ccb4b61d713d74
  Author: Johannes Löthberg <[hidden email]>
  Date:   2017-10-17 (Tue, 17 Oct 2017)

  Changed paths:
    M cheroot/server.py

  Log Message:
  -----------
  Add URL to MSDN page on SO_REUSEADDR semantics

Signed-off-by: Johannes Löthberg <[hidden email]>


  Commit: 93d77a279728bdf22de2fac4e7ecab1205988d46
      https://github.com/cherrypy/cheroot/commit/93d77a279728bdf22de2fac4e7ecab1205988d46
  Author: Sviatoslav Sydorenko <[hidden email]>
  Date:   2017-10-17 (Tue, 17 Oct 2017)

  Changed paths:
    M cheroot/server.py

  Log Message:
  -----------
  Don't use SO_REUSEADDR on Windows

PR #53 by @kyrias, closes cherrypy/cherrypy#1088


Compare: https://github.com/cherrypy/cheroot/compare/3e3ef2341af5...93d77a279728

--
You received this message because you are subscribed to the Google Groups "cherrypy-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/cherrypy-users.
For more options, visit https://groups.google.com/d/optout.