newforms feedback

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

newforms feedback

Alan Green-3

Hi Adrian,

I've been using newforms to implement a short form. Generally, it's
been a smooth ride, and I appreciate the flexibility and simplicity of
rendering compared to the old way. Between the doco, the examples in
the test case and the code, using it was straightforward too.

I have just three nits for you:

1. It would be nice if EmailField and URLField had max_length attributes.

2. When I tried to specify an empty label, with label='', I get the
automatically generated label. For example, here I try to give the url
field an empty label:

>>> from django.newforms import *
>>> class F(Form): url = URLField(label='')
...
>>> F().as_p()
u'<p><label for="id_url">Url:</label> <input type="text" name="url"
id="id_url" /></p>'

3. maxlength vs max_length is going to annoy me until it is made
consistent. I know you're working on it. :)

Cheers,

Alan

--
Alan Green
[hidden email] - http://bright-green.com

--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: newforms feedback

RonnyPfannschmidt

Hi, i just took a look at newforms, and the Lack of Function/Method
based Validators makes my work harder.

I'd like to see an Interface where i could define any Number of
Form-methods beginning with "clean_fieldname_" to define multiple
custom Validators for some Fields, as well as more than one Validatior
for the form-level


Ronny


--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply | Threaded
Open this post in threaded view
|

Re: newforms feedback

Adrian Holovaty-3
In reply to this post by Alan Green-3

On 12/19/06, Alan Green <[hidden email]> wrote:
> 1. It would be nice if EmailField and URLField had max_length attributes.

OK, I've added this in changeset [4241].

> 2. When I tried to specify an empty label, with label='', I get the
> automatically generated label.

Ah, I didn't anticipate people would want to use empty labels. In
changeset [4240], I added the ability to specify the empty string for
a label.

> 3. maxlength vs max_length is going to annoy me until it is made
> consistent. I know you're working on it. :)

Yeah, it annoys me, too. We'll eventually phase out maxlength in model
fields, in favor of max_length.

Adrian

--
Adrian Holovaty
holovaty.com | djangoproject.com

--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---